Import build flags from environment (a la Chisel2). #245
Conversation
chick
left a comment
chick
left a comment
There was a problem hiding this comment.
I think this looks ok, though I don't have the machinery to test this out.
Could there be a simple test, for instance, something that sets an env var that
calls a script in the test suite that shows arguments are picked up can run?
One minor quibble about a new line.
I was also wondering if there should be some output when environment variables are
overriding default values. Sometimes left-over env vars floating around can cause
weird behavior and it's difficult to know what's causing it.
| val CXXFLAGS = envOrElse("CXXFLAGS", "") | ||
| val CPPFLAGS = envOrElse("CPPFLAGS", "") | ||
| val LDFLAGS = envOrElse("LDFLAGS", "") | ||
| } |
There was a problem hiding this comment.
Good catch. Will fix.
|
If there's some urgency, maybe my comments should be turned into issues for testers2 so that |
|
I think this does need to be discussed. I like the idea of issuing some kind of notification when environment variables are used. |
Import
CC,CXX,CCFLAGS,CXXFLAGS,CPPFLAGS,LDFLAGSand incorporate them in the flags used to build C++ simulations.Although similar effects can be achieved via the
--more-vcs-flags, and--more-vcs-c-flagscommand line options, it's difficult to make these available to the internal ScalaTest suites.