Skip to content

Commit 192b7fc

Browse files
committed
[TASK] Use jQuery more efficiently in the test script
Cache elements instead of calling the same selector multiple times.
1 parent c4781ca commit 192b7fc

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

test/index.html

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -672,20 +672,22 @@ <h2>Disposal</h2>
672672
module("Disposal");
673673

674674
asyncTest("disposal", function() {
675-
$(".disposal.disposed").timeago('dispose');
676-
var initialTime_disposedTimeago = $(".disposal.disposed").html();
677-
var initialTime_activeTimeago = $(".disposal.notDisposed").html();
675+
var disposed = $(".disposal.disposed");
676+
var active = $(".disposal.notDisposed");
677+
disposed.timeago('dispose');
678+
var initialTime_disposedTimeago = disposed.html();
679+
var initialTime_activeTimeago = active.html();
678680

679681
expect(2);
680682
setTimeout(function() {
681-
var updatedTime_disposedTimeago = $(".disposal.disposed").html();
682-
var updatedTime_activeTimeago = $(".disposal.notDisposed").html();
683+
var updatedTime_disposedTimeago = disposed.html();
684+
var updatedTime_activeTimeago = active.html();
683685

684686
ok(initialTime_disposedTimeago === updatedTime_disposedTimeago, "A disposed timeago didn't get updated");
685687
ok(initialTime_activeTimeago !== updatedTime_activeTimeago, "A non-disposed timeago continued to be updated");
686688

687689
// Dispose still-active timeago
688-
$(".disposal.notDisposed").timeago('dispose');
690+
active.timeago('dispose');
689691
resetRefreshMillis();
690692
start();
691693
}, 50);

0 commit comments

Comments
 (0)