Skip to content

freaktechnik/eslint-plugin-array-func

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

27 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

eslint-plugin-array-func

Greenkeeper badge Build Status codecov

Rules for Array functions and methods.

Installation

Install ESLint either locally or globally.

$ npm install -D eslint

If you installed ESLint globally, you have to install the array-func plugin globally too. Otherwise, install it locally.

$ npm install -D eslint-plugin-array-func

Rules

from-map

Prefer using the mapFn callback of Array.from over an immediate .map() call on the Array.from result.

Array.from has a mapFn callback that lets you map the items of the iterable to an array like you would with .map() except that values have not yet been truncated to fit types allowed in an array. Some iterables can't be directly converted to an array and thus have to be iterated either way. In that case using the mapping callback of Array.from avoids an iteration. See also MDN for an explanation of the potential benefits of using the mapping callback of Array.from directly.

This rule is auto fixable. It will produce nested function calls if you use the Array.from map callback and have a .map() call following it.

Examples

Code that triggers this rule:

Array.from(iterable).map((t) => t.id);

Array.from(iterable, (t) => t.id).map((id) => id[0]);

Code that doesn't trigger this rule:

Array.from(iterable, (t) => t.id);

Array.from(iterable, function(t) { this.format(t); }, this);

const arr = Array.from(iterable);
const mappedArray = arr.map((t) => t.id);

no-unnecessary-this-arg

Avoid the this parameter when providing arrow function as callback in array functions.

The this parameter is useless when providing arrow functions, since the this of arrow functions can not be rebound, thus the parameter has no effect.

The fix is usually to omit the parameter. The Array methods can't be auto-fixed, since the detection of array methods is not confident enough to know that the method is being called on an array.

Checked functions

  • from (fixable)

Checked methods

  • every
  • filter
  • find
  • findIndex
  • forEach
  • map
  • some

Examples

Code that triggers this rule:

const array = Array.from("example", (char) => char.charCodeAt(0), this);

const e = array.find((char) => char === 101, this);

const exampleAsArray = array.map((char) => String.fromCharCode(char), this);

const eIndex = array.findIndex((char) => char === 101, this);

const containsE = array.some((char) => char === 101, this);

const isOnlyE = array.every((char) => char === 101, this);

const onlyEs = array.filter((char) => char === 101, this);

array.forEach((char) => console.log(char), this);

Code that doesn't trigger this rule:

const array = Array.from("example", (char) => char.charCodeAt(0));
const alternateArray = Array.from("example", function(char) {
    return char.charCodeAt(this)
}, 0);

const e = array.find((char) => char === 101);

const exampleAsArray = array.map((char) => String.fromCharCode(char));

const eIndex = array.findIndex((char) => char === 101);

const containsE = array.some((char) => char === 101);

const isOnlyE = array.every((char) => char === 101);

const onlyEs = array.filter(function(char) {
    return char === this
}, 101);

array.forEach(function(char) {
    this.log(char);
}, console);

array-func/recommended Configuration

The recommended configuration will set your parser ECMA Version to 2015, since that's when the Array functions and methods were added.

Rule Error level
from-map Error
no-unnecessary-this-arg Error

Using the configuration

To enable this configuration use the extends property in your .eslintrc.json config file (may look different for other config file styles):

{
    "extends": [
        "array-func/recommended"
    ]
}

License

The array-func plugin is licensed under the MIT License.