fix: handling company in bank reconciliation tool #45582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aayush7908
force-pushed
the
bank-reconciliation-company-default
branch
from
118b4ec to
b8d6ec2
Compare
aayush7908
changed the title
bank reconciliation tool
barredterra
reviewed
Feb 4, 2025
erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.js
Outdated
Show resolved
Hide resolved
barredterra
added
backport version-14-hotfix
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
barredterra
approved these changes
Feb 4, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com> (cherry picked from commit d1c9275)
mergify bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com> (cherry picked from commit d1c9275)
ruthra-kumar
added a commit
that referenced
this pull request
Feb 4, 2025
…-45582 fix: handling company in bank reconciliation tool (backport #45582)
ruthra-kumar
added a commit
that referenced
this pull request
Feb 4, 2025
…-45582 fix: handling company in bank reconciliation tool (backport #45582)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
# [14.82.0](v14.81.0...v14.82.0) (2025-02-05) ### Bug Fixes * allow multiple email ids ([9510758](9510758)) * bind this to function ([83bce78](83bce78)) * check billing address ([2f33f6b](2f33f6b)) * closing stock balance report not generating ([3f6beeb](3f6beeb)) * correct error message in payment entry ([9f5d7e4](9f5d7e4)) * default payment terms template selected while duplicating ([82cfafb](82cfafb)) * Gross Profit Report with Correct Totals and Gross Margin (backport [#45548](#45548)) ([#45597](#45597)) ([0086656](0086656)) * handling company in bank reconciliation tool ([#45582](#45582)) ([7823f1b](7823f1b)) * payment schedule table is empty while duplicating record ([d0ff91b](d0ff91b)) * **pos:** add item in the existing item row when discount is applied ([3c6ed0a](3c6ed0a)) * posting_date to posting_datetime in stock related queries ([bf3d68e](bf3d68e)) * renamed Commments Tab to Notes tab in Lead doctype ([0eddd1e](0eddd1e)) * track employee changes ([#45674](#45674)) ([43a5c33](43a5c33)) ### Features * set bank account of company to default company bank account from masters ([dac5307](dac5307))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
# [15.51.0](v15.50.1...v15.51.0) (2025-02-05) ### Bug Fixes * actual qty showing blank for sub-assembly items ([d0748b1](d0748b1)) * added correct options for incoming_rate field of delivery note item ([cfc5007](cfc5007)) * allow multiple email ids ([2a25302](2a25302)) * attribute 'msgbox' not found in sales invoice.js ([f6b4984](f6b4984)) * bind this to function ([c0b32c4](c0b32c4)) * check billing address ([44d9fb7](44d9fb7)) * closing stock balance report not generating ([47d1c3b](47d1c3b)) * conflicts ([4aa072a](4aa072a)) * consider process_loss_qty in work order ([1522d76](1522d76)) * copy correct uom from devliery note when creating packing list ([f9794e5](f9794e5)) * correct error message in payment entry ([6ea5307](6ea5307)) * default payment terms template selected while duplicating ([ca4bb96](ca4bb96)) * Do not check for cancelled invoices ([84638f5](84638f5)) * Do not check for cancelled invoices ([b612ab5](b612ab5)) * fetch rate from item price list when document is saved ([b140ce7](b140ce7)) * filter the item tax template using the input text ([8ea9a9e](8ea9a9e)) * Gross Profit Report with Correct Totals and Gross Margin (backport [#45548](#45548)) ([#45598](#45598)) ([6301b32](6301b32)) * handling company in bank reconciliation tool ([#45582](#45582)) ([aa27e19](aa27e19)) * ignore expired batch for pick list ([786db3d](786db3d)) * loading print receipt only at order complete (backport [#45627](#45627)) ([#45628](#45628)) ([72868ee](72868ee)) * logical error failing tests ([6a03f99](6a03f99)) * not able to make manufacturing entry for alternate items ([eef2f3c](eef2f3c)) * only system manager was able to create customer & prospect ([6149306](6149306)) * payment schedule table is empty while duplicating record ([c523625](c523625)) * point of sale padding (backport [#45697](#45697)) ([#45699](#45699)) ([b915e7f](b915e7f)) * pos payment cash shortcut decimal (backport [#45702](#45702)) ([#45705](#45705)) ([6113cc1](6113cc1)) * pos print receipt on submit (backport [#45632](#45632)) ([#45633](#45633)) ([676dde5](676dde5)) * **pos:** add item in the existing item row when discount is applied ([0b54cb9](0b54cb9)) * posting_date to posting_datetime in stock related queries ([cd5174e](cd5174e)) * remove tds account in taxes table on change of Tax Withholding Category ([1ad16c3](1ad16c3)) * removed unused field ([9a27d3c](9a27d3c)) * renamed Commments Tab to Notes tab in Lead doctype ([86edcfc](86edcfc)) * reposting issue with s3 backup ([73c1bf9](73c1bf9)) * resolved conflicts ([223fe62](223fe62)) * respect user set account if not advance account for getting outstanding invoices in payment entry ([8108d7f](8108d7f)) * semgrep ([401fd7f](401fd7f)) * set asset value correctly after cancelling value adjustment ([7f7f403](7f7f403)) * show only items with inspection enabled on create QI dialog ([34f8a37](34f8a37)) * slow SABB query ([7931c2d](7931c2d)) * subcontracting valiation precision issue ([5319683](5319683)) * track employee changes ([#45674](#45674)) ([cf98ebf](cf98ebf)) * validation message ([4742211](4742211)) * validation to prevent submission if the SABB is not linked to a stock transaction ([24a6f61](24a6f61)) ### Features * account heads changed along with journal entry type and descrip… ([#42845](#42845)) ([bbecd36](bbecd36)) * report to find incorrect SABB ([a948f2e](a948f2e)) * set bank account of company to default company bank account from masters ([b840271](b840271)) ### Performance Improvements * stock entry with batch (backport [#45486](#45486)) ([#45602](#45602)) ([8b75401](8b75401))
diptanilsaha
pushed a commit
to diptanilsaha/erpnext
that referenced
this pull request
Feb 14, 2025
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
In Bank Reconciliation Tool,
companyfield is not loaded with the default company value.So, API call made on selecting the
Bank Accountthrows error for missing value ofcompany.Default Company is not loaded when opening Bank Reconciliation Tool
An error is thrown when selecting Bank Account
Reference:
erpnext/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js
Line 9 in d748b49
backport version-14
backport version-15