remoteproc: qcom: Fix potential device node leaks

Tobias Jordan · andersson · commit 278d744c46fd · 2018-04-25T16:46:55.000-07:00
Add missing of_node_put()s at two places for device nodes returned by of_parse_phandle(). Fixes: 051fb70 ("remoteproc: qcom: Driver for the self-authenticating Hexagon v5") Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c
@@ -1083,6 +1083,7 @@ static int q6v5_alloc_memory_region(struct q6v5 *qproc)
 		dev_err(qproc->dev, "unable to resolve mba region\n");
 		return ret;
 	}
+	of_node_put(node);
 
 	qproc->mba_phys = r.start;
 	qproc->mba_size = resource_size(&r);
@@ -1100,6 +1101,7 @@ static int q6v5_alloc_memory_region(struct q6v5 *qproc)
 		dev_err(qproc->dev, "unable to resolve mpss region\n");
 		return ret;
 	}
+	of_node_put(node);
 
 	qproc->mpss_phys = qproc->mpss_reloc = r.start;
 	qproc->mpss_size = resource_size(&r);

Original file line number	Diff line number	Diff line change
`@@ -1083,6 +1083,7 @@ static int q6v5_alloc_memory_region(struct q6v5 *qproc)`
`1083`	`1083`	`dev_err(qproc->dev, "unable to resolve mba region\n");`
`1084`	`1084`	`return ret;`
`1085`	`1085`	`}`
	`1086`	`+ of_node_put(node);`
`1086`	`1087`
`1087`	`1088`	`qproc->mba_phys = r.start;`
`1088`	`1089`	`qproc->mba_size = resource_size(&r);`
`@@ -1100,6 +1101,7 @@ static int q6v5_alloc_memory_region(struct q6v5 *qproc)`
`1100`	`1101`	`dev_err(qproc->dev, "unable to resolve mpss region\n");`
`1101`	`1102`	`return ret;`
`1102`	`1103`	`}`
	`1104`	`+ of_node_put(node);`
`1103`	`1105`
`1104`	`1106`	`qproc->mpss_phys = qproc->mpss_reloc = r.start;`
`1105`	`1107`	`qproc->mpss_size = resource_size(&r);`