direct write buffer extension #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorstewart
force-pushed
the
feature/direct-write-buffer-fix
branch
from
aa09bd2 to
899dd8e
Compare
- Removed buggy direct write helpers from OutputBufferAdapter. - Added generic allocateForDirectWrite hook in OutputAdapterBaseCRTP (fails by default). - Added OutputAlignedBufferAdapter and InputAlignedBufferAdapter with explicit alignment enforcement. - Implemented allocateForDirectWrite in OutputAlignedBufferAdapter with correct padding and pointer arithmetic. - Added DirectWriteBuffer extension to simplify usage. - Added tests verifying alignment and data integrity.
victorstewart
force-pushed
the
feature/direct-write-buffer-fix
branch
from
899dd8e to
e8311c3
Compare
Restores the 'is_sufficiently_aligned' helper function in bitsery::details to resolve build failures in GitHub CI. This function, used by AlignedBufferAdapters, was missing after a recent rebase. The function includes two overloads: one for raw pointers and another for iterators, ensuring correct alignment checks for both cases. Necessary headers <type_traits> and <memory> have also been added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
okay sorry i finally got around to doing this lol
i adhered to all your design commentary here: #120
let me know what you think