feat: add user role management and refactor migrations

- Add API endpoint to update user roles (/update-role/:id)
- Add roleId field to User schema with Role reference
- Refactor migrations to use constants for role names
- Improve demo user creation with proper password hashing
- Remove redundant migration 004
- Update resource logging to use identifiers instead of IDs

Author: foyzulkarim

src/domains/user/api.js

@@ -12,13 +12,15 @@ const {
   followUser,
   deactivateUser,
   activateUser,
+  updateUserRole,
 } = require('./service');
 
 const {
   createSchema,
   updateSchema,
   idSchema,
   searchSchema,
+  updateUserRoleSchema,
 } = require('./request');
 const { validateRequest } = require('../../middlewares/request-validate');
 const { logRequest } = require('../../middlewares/log');
@@ -146,6 +148,22 @@ const routes = () => {
     }
   );
 
+  // update user's role only
+  router.put(
+    '/update-role/:id',
+    logRequest({}),
+    isAuthorized,
+    validateRequest({ schema: updateUserRoleSchema, isParam: false }),
+    async (req, res, next) => {
+      try {
+        const updatedUser = await updateUserRole(req.params.id, req.body);
+        res.status(200).json(updatedUser);
+      } catch (error) {
+        next(error);
+      }
+    }
+  );
+
   return router;
 };
 

src/domains/user/request.js

@@ -29,4 +29,8 @@ const searchSchema = Joi.object({
   order: Joi.string().valid('asc', 'desc'),
 });
 
-module.exports = { createSchema, updateSchema, idSchema, searchSchema };
+const updateUserRoleSchema = Joi.object().keys({
+  roleId: Joi.string().required(),
+});
+
+module.exports = { createSchema, updateSchema, idSchema, searchSchema, updateUserRoleSchema };

src/domains/user/schema.js

@@ -147,6 +147,10 @@ const schema = new mongoose.Schema({
     required: true,
     default: 'visitor',
   },
+  roleId: {
+    type: mongoose.Schema.Types.ObjectId,
+    ref: 'Role',
+  },
 });
 
 schema.add(baseSchema);

src/domains/user/service.js

@@ -1,5 +1,6 @@
 const logger = require('../../libraries/log/logger');
 const Model = require('./schema');
+const Role = require('../role/schema');
 const { AppError } = require('../../libraries/error-handling/AppError');
 const crypto = require('crypto');
 
@@ -134,6 +135,21 @@ const activateUser = async (id) => {
   }
 };
 
+const updateUserRole = async (id, payload) => {
+  try {
+    const item = await Model.findById(id);
+    const role = await Role.findById(payload.roleId);
+    item.role = role.name;
+    item.roleId = role._id;
+    await item.save();
+    logger.info(`updateUserRole(): ${model} updated`, { id, role: item.role });
+    return item;
+  } catch (error) {
+    logger.error(`updateUserRole(): Failed to update ${model}`, error);
+    throw new AppError(`Failed to update ${model}`, error.message);
+  }
+}
+
 const getByGitHubId = async (githubId) => {
   return await Model.findOne({ 'github.id': githubId });
 };
@@ -298,4 +314,5 @@ module.exports = {
   getByGoogleId,
   findByVerificationToken,
   refreshVerificationToken,
+  updateUserRole,
 };

src/migrations/001-add-initial-resources.js

@@ -160,7 +160,7 @@ async function insertResource(resource) {
       return;
     }
     const result = await Resource.create(resource);
-    console.log(`Inserted resource: ${resource._id}`);
+    console.log(`Inserted resource: ${resource.identifier}`);
     return result;
   } catch (error) {
     console.error(`Error inserting resource ${resource.id}:`, error);

src/migrations/002-add-roles-permissions.js

@@ -1,9 +1,10 @@
 const Model = require('../domains/role/schema');
+const { ROLES } = require('./constants');
 
 const data = {
   roles: [
     {
-      name: 'Super admin',
+      name: ROLES.SUPER_ADMIN,
       identifier: 'superadmin',
       isSystemManaged: true,
       permissions: {
@@ -30,7 +31,7 @@ const data = {
       },
     },
     {
-      name: 'Admin',
+      name: ROLES.ADMIN,
       identifier: 'admin',
       isSystemManaged: true,
       permissions: {
@@ -39,11 +40,13 @@ const data = {
           '/api/v1/users/count',
           '/api/v1/users/detail/:id',
         ],
-        client: [],
+        client: [
+          'sidebar-users',
+        ],
       },
     },
     {
-      name: 'Visitor',
+      name: ROLES.VISITOR,
       identifier: 'visitor',
       isSystemManaged: true,
       permissions: {
@@ -76,10 +79,10 @@ async function insert(item) {
       return;
     }
     const result = await Model.create(item);
-    console.log(`Inserted role: ${item._id}`);
+    console.log(`Inserted role: ${item.identifier}`);
     return result;
   } catch (error) {
-    console.error(`Error inserting role ${item._id}:`, error);
+    console.error(`Error inserting role ${item.identifier}:`, error);
     throw error;
   }
 }

src/migrations/003-add-users.js

@@ -1,6 +1,8 @@
 const User = require('../domains/user/schema');
+const Role = require('../domains/role/schema');
 const bcrypt = require('bcrypt');
 const config = require('../configs');
+const { ROLES } = require('./constants');
 
 async function insert(user) {
   try {
@@ -10,8 +12,10 @@ async function insert(user) {
       console.log(`${user.displayName} already exists: ${user.email}`);
       return;
     }
+
+    user.roleId = await Role.findOne({name: user.role});
     const result = await User.create(user);
-    console.log(`Inserted ${user.displayName}: ${result._id}`);
+    console.log(`Inserted ${user.displayName}`);
     return result;
   } catch (error) {
     console.error(`Error inserting ${user.displayName}:`, error);
@@ -54,12 +58,12 @@ async function runMigration() {
       authType: 'local',
       local: {
         username: 'admin@example.com',
-        password: 'password', // sample password for demo purposes
+        password: await bcrypt.hash('password', salt),
       },
-      isDemo: false,
+      isDemo: true,
       isVerified: true,
       isAdmin: true,
-      role: 'admin'
+      role: ROLES.ADMIN
     };
 
     await insert(adminUser);
@@ -70,12 +74,12 @@ async function runMigration() {
       authType: 'local',
       local: {
         username: 'visitor@example.com',
-        password: 'password', // sample password for demo purposes
+        password: await bcrypt.hash('password', salt),
       },
-      isDemo: false,
+      isDemo: true,
       isVerified: true,
       isAdmin: false,
-      role: 'visitor'
+      role: ROLES.VISITOR
     };
 
     await insert(visitorUser);

src/migrations/004-update-demo-users.js

@@ -0,0 +1,9 @@
+const ROLES = {
+  SUPER_ADMIN: 'Super admin',
+  ADMIN: 'Admin',
+  USER: 'User',
+  DEMO: 'Demo',
+  VISITOR: 'Visitor',
+}
+
+module.exports = { ROLES };