Skip to content

Commit 206e38e

Browse files
addaleaxfoxxyz
authored andcommitted
src: add not-weak DCHECK to PersistentToLocal::Strong
Refs: nodejs#38821 (comment) PR-URL: nodejs#38875 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 7554930 commit 206e38e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/util.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -760,6 +760,7 @@ class PersistentToLocal {
760760
template <class TypeName>
761761
static inline v8::Local<TypeName> Strong(
762762
const v8::PersistentBase<TypeName>& persistent) {
763+
DCHECK(!persistent.IsWeak());
763764
return *reinterpret_cast<v8::Local<TypeName>*>(
764765
const_cast<v8::PersistentBase<TypeName>*>(&persistent));
765766
}

0 commit comments

Comments
 (0)