Halfling Lucky not applied properly

[aaclayton]

Originally in GitLab by @slcao2

According to the SRD rules around advantage/disadvantage when applied with the Halfling Lucky trait, you can reroll only one of the dice if you roll a 1. So for instance, if are rolling with and roll a 1 on both rolls, you can only reroll one of the 1s. https://5thsrd.org/rules/advantage_and_disadvantage/

With how it is currently implemented, advantage gives you a formula like 2d20r=1kh which ends up rerolling both dice if they are both 1s. While I haven't seen it on that case specifically, replicating something similar, like 2d20r<15 ends up rerolling both dice and I assume that it would do similar for the 2d20r=1kh case.

[aaclayton]

Hmm, you are correct that it should be applied as r1=1

[aaclayton]

mentioned in commit 5e7445a