Spells that can consume "other" item charges should not automatically consume them

[aaclayton]

Originally in GitLab by @DarKDinDoN

Hello,

Since 0.94 we can configure spells so they can consume another item charge (e.g: consume feat charge).
That's very nice, but casting the spell always consumes the charge. Can you add a checkbox in the spell casting dialog so the player can chose between:

• Consume a spell slot
• Consume the own spell charges (if configured)
• Consume another spell charges (if configured)

[aaclayton]

Originally in GitLab by @trioderegion

I'm taking a stab at this one. To make sure I understand the use-case, is this the desired result?

[aaclayton]

Originally in GitLab by @DarKDinDoN

@trioderegion looks like it.

The "Consume Resource" is used for both use-cases?

• Consume the own spell charges (if configured)
• Consume another spell/feat/item charges (if configured)

[aaclayton]

Originally in GitLab by @trioderegion

Indeed it does. Here is the configuration dialog for a spell that:

• Consumes a slot (Consume Spell Slot?)
• Consumes its own charges or uses (Consume Available Usage?)
• Consumes a different items's charges or uses (Consume Resource?)
• Has an AOE effect (Place Measured Template)

[aaclayton]

Originally in GitLab by @DarKDinDoN

Perfect ❤️

[aaclayton]

Originally in GitLab by @trioderegion

One thing to note. I mirrored the logic of resource consumption from other items. During testing, the spell will only be truly "blocked" from casting if you have no spell slots remaining.

If you have slots remaining but are missing either an Available Usage OR a Resource, the spell will still be cast and the uses/resources you do have will be deducted. If either have no uses left, a warning will be shown to the player indicating the item does not have enough of the required charges to use.

E.g.:
You have 1 slot, 1 usage, but are out of the required material component (Resource). If you cast a spell, your resulting state will be -- 0 slots, 0 usages, 0 resources, but the spell will be cast with a warning indicating there wasnt enough Item Usages (from the consumed resource).

[aaclayton]

mentioned in commit d0e8b57

[aaclayton]

marked this issue as related to #856