Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item5e rollAttack and rollToolCheck don't pass options through to d20Roll call #622

Closed
schultzcole opened this issue Aug 8, 2020 · 0 comments
Assignees
Labels
api bug Functionality which is not working as intended
Milestone

Comments

@schultzcole
Copy link
Collaborator

It would be nice for macros to be able to call Item5e#rollAttack or Item5e#rollToolCheck with all of the same options that d20Roll expects. The specific example that came up was advantage and disadvantage, but I can see a bunch of these options as being useful, including critical, fumble, and targetValue.

Here's an example of what we would like to be able to do in a macro (example courtesy of Kekilla):

// Assuming `item` is defined
item.rollAttack({ advantage: true });
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api bug Functionality which is not working as intended
Projects
None yet
Development

No branches or pull requests

2 participants