Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom elements lose styling when moved between hosts #3044

Closed
lphillips opened this issue Feb 13, 2024 · 4 comments
Closed

Custom elements lose styling when moved between hosts #3044

lphillips opened this issue Feb 13, 2024 · 4 comments
Assignees
Labels
bug Functionality which is not working as intended
Milestone

Comments

@lphillips
Copy link

lphillips commented Feb 13, 2024

The dnd5e 3.0 system is no longer compatible with the PopOut! module. The character sheet relies on various CSS and Javascript features that make it incompatible, causing rendering issues that make the sheet unusable in a pop out window. Details can be found in this issue report in the PopOut! repo: League-of-Foundry-Developers/fvtt-module-popout#109

I know that there's no guarantee of compatibility with any given third-party module, but the ability to pop out a character sheet or journal entry to a separate window helps a lot with managing all the characters and notes you have when running or playing the game. If it's not feasible to maintain compatibility with PopOut! then it would be great to have the ability to open a character sheet in a separate window be part of the dnd5e system.

@Ator27
Copy link

Ator27 commented Feb 13, 2024

I updated because the new dnd5e 3.0 just looked so cool. Sadly, I will continue to set the default to the character sheets to the old sheets because people use the popouts so much. Maybe I'm overstating this and maybe I'm also in the minority, but I really think making this update work with popout module should be considered.

@Vengrath97
Copy link

+1

@guldelox
Copy link

+1 This module was very useful in streamlining workflow during a game and preventing people from having to hunt through windows and journals and sheets. Definitely a Quality of Life thing that ideally would be core Foundry functionality, but it's understandable that it may need to be done at the System level rather than Core.

@schultzcole
Copy link
Collaborator

Looping in #3048 for posterity's sake

@arbron arbron added the bug Functionality which is not working as intended label Feb 22, 2024
@arbron arbron added this to the D&D5E 3.0.4 milestone Feb 22, 2024
@Fyorl Fyorl changed the title Support PopOut! module compatibility with new character sheet Custom elements lose styling when moved between hosts Mar 1, 2024
@Fyorl Fyorl closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended
Projects
None yet
Development

No branches or pull requests

7 participants