Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Advancement API guide to wiki #1481

Closed
Fyorl opened this issue Apr 20, 2022 · 7 comments
Closed

Add Advancement API guide to wiki #1481

Fyorl opened this issue Apr 20, 2022 · 7 comments
Assignees
Labels
api documentation Improvements or additions to documentation

Comments

@Fyorl
Copy link
Contributor

Fyorl commented Apr 20, 2022

Originally in GitLab by @Fyorl

@Fyorl
Copy link
Contributor Author

Fyorl commented Apr 20, 2022

Originally in GitLab by @arbron

Is this a plan to start making use of the wiki here on GitLab?

@Fyorl
Copy link
Contributor Author

Fyorl commented Apr 21, 2022

Originally in GitLab by @Fyorl

Yeah, I think so. I think we discussed something like this back when we did the initial planning but the details are a bit fuzzy. I think an API guide would be useful, and the wiki seems like the best place for it from what I can tell.

@Fyorl
Copy link
Contributor Author

Fyorl commented Apr 22, 2022

Originally in GitLab by @arbron

Okay, I've begun work on an advancement page for the wiki.

Unfortunately GitLab wikis don't support Merge Requests, so I wasn't able to do the work on my own fork.

@Fyorl
Copy link
Contributor Author

Fyorl commented Apr 22, 2022

Originally in GitLab by @Fyorl

Thanks Jeff, I was planning on doing it myself today but adding extra typing to scale values just sucked up the entire day. You are probably best placed to write about the API anyway, I think you can feel free to edit the wiki as you please.

@Fyorl
Copy link
Contributor Author

Fyorl commented Apr 22, 2022

Originally in GitLab by @akrigline

I'm not 100% about this, worth testing to be sure, but I think if a module registers an advancement during init it will have done so after the system's init and thus too late for item preparation?

@Fyorl
Copy link
Contributor Author

Fyorl commented Apr 22, 2022

Originally in GitLab by @arbron

In my testing item preparation didn't occur until after the "setup" hook was called.

@Fyorl
Copy link
Contributor Author

Fyorl commented Apr 22, 2022

Originally in GitLab by @akrigline

gotchya, perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants