Support Advantage/Disadvantage flags and Chat Flavor Text to skills/saves/checks

[aaclayton]

Originally in GitLab by @MaxPat931

Related to ongoing work at https://gitlab.com/foundrynet/dnd5e/-/merge_requests/323 / https://gitlab.com/foundrynet/dnd5e/-/issues/1176

Add the option to flag a skill/save/check as having Advantage or Disadvantage, could be used to create a visual reminder on the character sheet, and fast-forward rolls (or allow rolling modules to use the field for that purpose)

Use Cases - Heavy armor grants disadvantage to Stealth checks, the Rune Knight's Cloud Rune's passive abilities give advantage on DEX (Sleight of Hand) checks and CHA (Deception) checks.

Add the option for a Chat flavor text field, similar to items

Use Cases - Reminders for situational bonuses e.g. War Caster's "You have advantage on Constitution saving throws that you make to maintain your concentration on a spell when you take damage."

[aaclayton]

Originally in GitLab by @arbron

Related to #809

[aaclayton]

Originally in GitLab by @MaxPat931

Just found https://gitlab.com/foundrynet/dnd5e/-/issues/874 which essentially looks to be requesting Chat Flavor Text as well, sorry for duplicating :)

[aaclayton]

From a philosophical/design perspective, I don't like an approach which permanently associates a skill with advantage or disadvantage since everything is situational in 5e.

I do understand however that there are mechanics which roughly translate as characters normally having adv/disadv on particular rolls - but even then it's easy for those to be offset and cancelled out by some other circumstance.

I think handling this as an active effect makes sense and is faithful to the extent to which such things are transient - but active effects need something in the base data to hook onto and modify, so it's a bit of a puzzle how to do this in a non-ugly way.

[aaclayton]

Originally in GitLab by @tposney

Doesn't this tie into the discussion about flags.advantage to represent advantage?

[aaclayton]

Originally in GitLab by @MaxPat931

I guess I should have created a screenshot that showed what I was thinking the implementation could look like, rather than just the effects it could generate.

Using a screenshot from !323 I was imagining something like this

and I agree with the situational comments, there should definitely be flexibility to account for the many circumstances that could arise in game, but a fighter wearing Plate will have disadvantage on Stealth more often than not, so having a way to notate that on the Stealth proficiency would be very helpful

[revilowaldow]

Would be really keen to see this, especially in the new context. This is similar to D&D beyond's advantage disadvantage flags on saves etc from features and with the new design of the 3.0 sheet would be a great fit

[Rabulias]

Possibly related request: Ticket 1154

[revilowaldow]

Now that #809 is complete this should be much easier to implement?