Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for modules to specify new base items without having to duplicate Items compendium #1205

Closed
arbron opened this issue Jul 22, 2021 · 1 comment

Comments

@arbron
Copy link
Collaborator

arbron commented Jul 22, 2021

Currently, base items (such as from DND5E.weaponIds) can only be fetched from the compendium listed in DND5E.sourcePacks.ITEMS. This means that any module that wants to add a new base weapon for example, has to completely duplicate all of the items referenced by id in config into their own compendium and change DND5E.sourcePacks to reference their new pack. This is a lot of work and makes it impossible for two different modules to modify the base item types.

I propose a change to how these base item ID lists are handled to allow two different formats: the current format of simply the ID (e.g. "Gflnp29aEv5Lc1ZM") which would cause the item to be looked up in the DND5E.sourcePacks.ITEMS compendium, and a new format that specifies the pack name and ID for the lookup (e.g. "myModule.new-items.Gflnp29aEv5Lc1ZM").

This change should make it easy for module makers to introduce new base items.

@arbron
Copy link
Collaborator Author

arbron commented Jul 22, 2021

Originally in GitLab by @aaclayton

This is a good suggestion, but im not comfortable with adding scope to %"D&D5E 1.4.0 - Armor Class Automation" at the moment. We need to consider that milestone as basically closed at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant