Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add creature type data to character type Actors #1202

Closed
aaclayton opened this issue Jul 19, 2021 · 2 comments
Closed

Add creature type data to character type Actors #1202

aaclayton opened this issue Jul 19, 2021 · 2 comments
Labels
Milestone

Comments

@aaclayton
Copy link
Contributor

Originally in GitLab by @thatlonelybugbear

Let's say you want to create a Humanoid (High Elf).

Creating a character type actor, filling the Race field in the character sheet, it populates the data.data.details.race with the string "Humanoid (High Elf)".

Creating a npc type actor, filling the race in the NPC character, by choosing: Humanoid and typing in the subtype: (High Elf), it populates the data.data.details.type with {custom: "", subtype: "High Elf", swarm: "", value: "humanoid"}.
In this case it also creates under the Actor5e, labels an entry for creatureType: "Humanoid (High Elf)" and type: "Humanoid (High Elf)".

When you try in a macro to search for this specific race (High Elf) you need to differentiate the search string for the differences between the npc and pc actor structure.

A way to have a unformal way of storing the race data for both character and npc would make things more straightforward in my opinion.

Another quicker fix would be for the character type actors to also automatically create an entry under labels with the same structure like the one for ncp's and then search this entry.

Hope this makes sense.

@aaclayton
Copy link
Contributor Author

I don't quite understand what you mean by this, but this seems probably related to the planned work in #342

@aaclayton
Copy link
Contributor Author

Originally in GitLab by @thatlonelybugbear

I managed to even confuse myself...

A player and a npc with the same race.

image

Actor5e data for Player (data.type: "character")
image

Actor5e data for NPC (data.type: "npc")
image

The differences in the structure of the Actor data for npc and player makes writing of macros involving searching for specific "types" of creature not that straightforward.

I guess the planned work you mention would take care of that.

@Fyorl Fyorl added the api label Jul 3, 2023
@Fyorl Fyorl changed the title Uniform key in Actordata regarding race for type:character and type:npc Add creature type data to character type Actors Nov 10, 2023
@Fyorl Fyorl added this to the D&D5E 2.4.0 milestone Nov 10, 2023
@Fyorl Fyorl closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants