Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move max level cap into config #1094

Closed
arbron opened this issue May 2, 2021 · 0 comments
Closed

Move max level cap into config #1094

arbron opened this issue May 2, 2021 · 0 comments
Assignees
Labels

Comments

@arbron
Copy link
Collaborator

arbron commented May 2, 2021

Currently, the max level cap of 20 is hardcoded as a magic number in a number of places throughout the codebase. This makes it difficult to find where the level cap is used and very difficult for any module that wants to modify the level cap in 5e (e.g. any module that wants to implement post-level-20 content).

I propose adding a new constant into the config file DND5E.levelCap which defaults to 20 to allow for a single point of customization and more self-documenting code.

Additional Idea

One other idea is also adding a DND5E.classLevelCap which is a separate cap for classes to allow characters and classes to be capped at a different level (e.g. if you wanted classes to max out at level 20, but allow multi-classing for players to higher levels past that).

Alternative Naming

DND5E.maxLevel (+ DND5E.maxClassLevel)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant