Add tests for the conversions crate #944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cptartur
requested review from
a team,
Arcticae,
MaksymilianDemitraszek,
Radinyn and
war-in
and removed request for
a team
Arcticae
requested changes
Oct 24, 2023
Collaborator
Arcticae
left a comment
Arcticae
left a comment
There was a problem hiding this comment.
This seems fine by me, although please add more values from which we test the conversions (the ones that could be problematic, boundary values etc.)
war-in
reviewed
Oct 24, 2023
Contributor
war-in
left a comment
war-in
left a comment
There was a problem hiding this comment.
Do you think some tests for errors would be suitable?
Contributor
Author
|
Added boundary values and error tests. Please your review 🔎 |
war-in
reviewed
Oct 30, 2023
Co-authored-by: Marcin Warchoł <61014013+war-in@users.noreply.github.com>
Co-authored-by: Marcin Warchoł <61014013+war-in@users.noreply.github.com>
Arcticae
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #599
Introduced changes
Add tests for the conversions crate
Breaking changes
N/A
Checklist
CHANGELOG.md