perf(forge): parallelize stateless fuzzing #12713
Open
+1,165
−395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es that provided in new coverage
…tore the workers id that found the failure
…cally to prevent going over max_runs
…when not in tokio
DaniPopes
requested review from
0xrusowsky,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
This was referenced Dec 2, 2025
DaniPopes
force-pushed
the
dani/parallel-fuzz
branch
from
6f9f793 to
178f82a
Compare
DaniPopes
force-pushed
the
dani/parallel-fuzz
branch
from
178f82a to
e803c4a
Compare
- Unified CorpusEntry constructors with internal _new method taking
Option<PathBuf> to eliminate code duplication between new and
from_tx_seq.
- Extracted common helper methods in WorkerCorpus:
- can_replay_tx: static helper to check if tx can be replayed,
replacing 2 duplicate closures.
- file_extension: returns appropriate file extension based on gzip
config, replacing 3 duplicated patterns.
- Simplified directory initialization using functional map pattern
instead of nested if-let, and removed unnecessary is_dir checks
before create_dir_all calls.
- Improved parse_corpus_filename by replacing rsplitn + collect with
rsplit_once for better efficiency and added proper error message for
invalid format.
- Removed unused uuid field from CorpusDirEntry struct, fixing clippy
dead_code warning.
- Reordered early returns in export method to check master worker
first for more logical flow.
DaniPopes
force-pushed
the
dani/parallel-fuzz
branch
from
9a73821 to
3df9d00
Compare
0xalpharush
reviewed
Dec 5, 2025
| counterexample: (calldata, call), | ||
| breakpoints, | ||
| })) | ||
| rayon::current_num_threads() as u32 |
Contributor
There was a problem hiding this comment.
It's unclear to me if this would be 0 if threads config is omitted
foundry/crates/cli/src/opts/global.rs
Lines 67 to 69 in a78c89f
If it's all available threads, I'm wondering if it may exacerbate issues like this #12397. Would it make sense to take memory into account and lower the thread count accordingly or default to a lower num?
Member
Author
There was a problem hiding this comment.
Yes it would, the default is number of threads. i don't think this would have memory issues more than the current implementation, but it does exacerbate storage instead since we never prune anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8898.
Continuation of #11769 + #11842. See these PRs for more details.