Skip to content

fix(anvil): latest evm version should be prague #10653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025

Conversation

yash-atreya
Copy link
Member

Motivation

Closes #10652

Solution

Return Prague as the default/latest hardfork in get_hardfork

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@zerosnacks
Copy link
Member

zerosnacks commented May 28, 2025

This will be included in https://github.com/foundry-rs/foundry/pull/10565/files#diff-b3368a1345af0c697efe45acd7cc1686b8722f6f235a1d16549f7890b48a0a88 but I'm OK with merging this prior to unblock - want to evaluate some unexpected changes more (change in gas, change in CREATE2 address)

mattsse
mattsse previously approved these changes May 28, 2025
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, this should be prague

Comment on lines 534 to 536
return OpHardfork::Isthmus.into();
}
EthereumHardfork::Cancun.into()
EthereumHardfork::Prague.into()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can then use ::default() here for both

@yash-atreya yash-atreya marked this pull request as ready for review May 28, 2025 11:47
@zerosnacks zerosnacks self-requested a review May 28, 2025 12:01
@yash-atreya yash-atreya merged commit db0ce45 into master May 28, 2025
22 checks passed
@yash-atreya yash-atreya deleted the yash/evm-latest-prague branch May 28, 2025 12:03
@github-project-automation github-project-automation bot moved this to Done in Foundry May 28, 2025
Dargon789 pushed a commit to Dargon789/foundry that referenced this pull request May 28, 2025
* fix(`anvil`): latest evm version should be prague

* fix test

* nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

hardfork --latest option doesn't leat to Prague being selected as hardfork
3 participants