feat(cast mktx): add support for "--ethsign" option #10641
Merged
+50
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mablr
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
mablr
force-pushed
the
feature/cast-mktx-ethsign
branch
from
cc97a3b to
0301a53
Compare
mattsse
requested changes
May 26, 2025
mablr
commented
May 26, 2025
- Sign transactions using "eth_signTransaction" on local node with unlocked accounts. - Same TX building logic as in "cast send --unlocked". - Added a test case to validate the new functionality.
mablr
force-pushed
the
feature/cast-mktx-ethsign
branch
from
2e35b7e to
f8db86b
Compare
|
I fixed everything and squashed intermediate commits. Thanks @mattsse for your feedback! |
mattsse
approved these changes
May 26, 2025
Dargon789
pushed a commit
to Dargon789/foundry
that referenced
this pull request
May 28, 2025
- Sign transactions using "eth_signTransaction" on local node with unlocked accounts. - Same TX building logic as in "cast send --unlocked". - Added a test case to validate the new functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #10629 by adding "--ethsign" option to
cast mktxcommand.Solution
Remarks
This new "--ethsign" option conflicts with "--raw-unsigned", this is properly declared in the Clap macro.
PR Checklist
Added Documentation