Skip to content

feat(forge): eip712 cheatcodes + forge cmd (eip712 + bind-json) with solar #10510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

feat(forge): eip712 cheatcodes + forge cmd (eip712 + bind-json) with solar #10510

wants to merge 45 commits into from

Conversation

0xrusowsky
Copy link
Contributor

@0xrusowsky 0xrusowsky commented May 13, 2025 •
edited
Loading

this PR combines 3 smaller PRs which serve several purposes:

motivation:

to-do

  • reimplement eip712 using solar
  • integrate with forge bind-json
  • implement eip712 cheatcodes
  • fix compilers test regression (vyper does not support Prague yet)
  • fix merge conflicts
  • update docs: docs: eip712 book#1526

DaniPopes
DaniPopes reviewed May 14, 2025
View reviewed changes
DaniPopes
DaniPopes reviewed May 14, 2025
View reviewed changes
@0xrusowsky 0xrusowsky requested a review from DaniPopes May 16, 2025 15:13
0xrusowsky
0xrusowsky commented May 16, 2025
View reviewed changes
DaniPopes
DaniPopes reviewed May 19, 2025
View reviewed changes
@0xrusowsky 0xrusowsky requested a review from DaniPopes May 19, 2025 15:24
@0xrusowsky
Copy link
Contributor Author

@DaniPopes lmk once u release the patch and i will update the toml

@grandizzy grandizzy linked an issue May 22, 2025 that may be closed by this pull request
Cheatcode: EIP712 canonical hashing #4818
Open
@DaniPopes
Copy link
Member

Can we rename PR to reflect addition of new cheatcodes?

@0xrusowsky 0xrusowsky changed the title feat(forge): eip712 with solar feat(forge): eip712 with solar + new eip712 cheatcodes May 29, 2025
@0xrusowsky 0xrusowsky changed the title feat(forge): eip712 with solar + new eip712 cheatcodes feat(forge): eip712 cheatcodes + forge cmd (eip712 + json-bind) with solar May 29, 2025
@0xrusowsky 0xrusowsky changed the title feat(forge): eip712 cheatcodes + forge cmd (eip712 + json-bind) with solar feat(forge): eip712 cheatcodes + forge cmd (eip712 + bind-json) with solar May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cheatcode: EIP712 canonical hashing
2 participants
@0xrusowsky @DaniPopes