You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we pass around DB generic everywhere for very little gain. I believe if we used Box<dyn Database> or similar we could remove all of these generics, make Cheatcode object-safe unifying it with DynCheatcode, and generally deduplicate code.
how would we handle this when ccx.ecx.db would be a concrete type?
I think this is the only blocker rn, and one of the biggest pain points which I've also encountered when looking into custom precompiles, because ContextPrecompiles<DB> couldn't be reused when creating those references
Component
Other (please describe)
Describe the feature you would like
Currently we pass around DB generic everywhere for very little gain. I believe if we used
Box<dyn Database>
or similar we could remove all of these generics, makeCheatcode
object-safe unifying it withDynCheatcode
, and generally deduplicate code.Made possible by recent improvements by @klkvr
Additional context
No response
The text was updated successfully, but these errors were encountered: