#[cfg(feature = "render")] and yew::Renderer (yewstack#2498)

* Bring changes to this branch.

* Bring changes to this branch.

* Add feature render and renderer.

* Bring changes to this branch.

* Migrate examples to Renderer.

* Satisfy no any render.

* Satisfy ssr.

* Satisfy feature render.

* Lint feature soundness.

* Suppress tests.

* Fix pr-flow, update docs.

* Add a notice.

* Adjust visibility.

* Correctly feature gate tests.

* make test scope available under feature render.

* Fix CI.

* Fix CI.

* Restore tests module to its original place as well.

* Make bundles crate private.

* Make most bundle APIs private.

* Adjust docs.

* Adjust debug implementation.

* Replace start_app with Renderer.

* Adjust documentation.

* Remove unused lint.

* Remove start_app from docs.

* DomBundle -> ReconcileTarget.

* Adjust documentation.

* Once render, now csr.

* Fix docs as well.

Author: futursolo

.github/workflows/main-checks.yml

@@ -27,6 +27,14 @@ jobs:
           command: clippy
           args: --all-targets -- -D warnings
 
+      - name: Lint feature soundness
+        run: |
+          cargo clippy -- --deny=warnings
+          cargo clippy --features=ssr -- --deny=warnings
+          cargo clippy --features=csr -- --deny=warnings
+          cargo clippy --all-features --all-targets -- --deny=warnings
+        working-directory: packages/yew
+
 
   clippy-release:
     name: Clippy on release profile
@@ -49,6 +57,14 @@ jobs:
           command: clippy
           args: --all-targets --release -- -D warnings
 
+      - name: Lint feature soundness
+        run: |
+          cargo clippy --release -- --deny=warnings
+          cargo clippy --release --features=ssr -- --deny=warnings
+          cargo clippy --release --features=csr -- --deny=warnings
+          cargo clippy --release --all-features --all-targets -- --deny=warnings
+        working-directory: packages/yew
+
 
   doc_tests:
     name: Documentation Tests
@@ -180,4 +196,3 @@ jobs:
         with:
           command: test
           args: -p yew-macro test_html_lints --features lints
-

examples/agents/Cargo.toml

@@ -9,6 +9,6 @@ license = "MIT OR Apache-2.0"
 log = "0.4"
 serde = { version = "1.0", features = ["derive"] }
 wasm-logger = "0.2"
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 yew-agent = { path = "../../packages/yew-agent" }
 gloo-timers = "0.2"

examples/agents/src/bin/app.rs

@@ -1,4 +1,4 @@
 fn main() {
     wasm_logger::init(wasm_logger::Config::default());
-    yew::start_app::<agents::App>();
+    yew::Renderer::<agents::App>::new().render();
 }

examples/boids/Cargo.toml

@@ -11,7 +11,7 @@ anyhow = "1.0"
 getrandom = { version = "0.2", features = ["js"] }
 rand = "0.8"
 serde = { version = "1.0", features = ["derive"] }
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 gloo = "0.6"
 
 [dependencies.web-sys]

examples/boids/src/main.rs

@@ -162,5 +162,5 @@ impl App {
 }
 
 fn main() {
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/contexts/Cargo.toml

@@ -6,5 +6,5 @@ license = "MIT OR Apache-2.0"
 
 [dependencies]
 serde = { version = "1.0", features = ["derive"] }
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 yew-agent = { path = "../../packages/yew-agent" }

examples/contexts/src/main.rs

@@ -19,5 +19,5 @@ pub fn App() -> Html {
 }
 
 fn main() {
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/counter/Cargo.toml

@@ -8,5 +8,5 @@ license = "MIT OR Apache-2.0"
 [dependencies]
 gloo-console = "0.2"
 js-sys = "0.3"
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 wasm-bindgen = "0.2"

examples/counter/src/main.rs

@@ -72,5 +72,5 @@ impl Component for App {
 }
 
 fn main() {
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/dyn_create_destroy_apps/Cargo.toml

@@ -7,7 +7,7 @@ license = "MIT OR Apache-2.0"
 
 [dependencies]
 js-sys = "0.3"
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 slab = "0.4.3"
 gloo = "0.6"
 wasm-bindgen = "0.2"

examples/dyn_create_destroy_apps/src/main.rs

@@ -55,14 +55,15 @@ impl Component for App {
                 // Get the key for the entry and create and mount a new CounterModel app
                 // with a callback that destroys the app when emitted
                 let app_key = app_entry.key();
-                let new_counter_app = yew::start_app_with_props_in_element(
+                let new_counter_app = yew::Renderer::<CounterModel>::with_root_and_props(
                     app_div.clone(),
                     CounterProps {
                         destroy_callback: ctx
                             .link()
                             .callback(move |_| Msg::DestroyCounterApp(app_key)),
                     },
-                );
+                )
+                .render();
 
                 // Insert the app and the app div to our app collection
                 app_entry.insert((app_div, new_counter_app));
@@ -107,5 +108,5 @@ impl Component for App {
 
 fn main() {
     // Start main app
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/file_upload/Cargo.toml

@@ -7,7 +7,7 @@ license = "MIT OR Apache-2.0"
 
 [dependencies]
 js-sys = "0.3"
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 gloo-file = "0.2"
 
 [dependencies.web-sys]

examples/file_upload/src/main.rs

@@ -124,5 +124,5 @@ impl App {
 }
 
 fn main() {
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/function_memory_game/Cargo.toml

@@ -13,7 +13,7 @@ gloo = "0.6"
 nanoid = "0.4"
 rand = "0.8"
 getrandom = { version = "0.2", features = ["js"] }
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 
 [dependencies.web-sys]
 version = "0.3"

examples/function_memory_game/src/main.rs

@@ -6,5 +6,5 @@ mod state;
 use crate::components::app::App;
 
 fn main() {
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/function_router/Cargo.toml

@@ -21,3 +21,6 @@ wasm-logger = "0.2"
 
 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
 instant = { version = "0.1" }
+
+[features]
+csr = ["yew/csr"]

examples/function_router/index.html

@@ -11,6 +11,7 @@
       href="https://cdn.jsdelivr.net/npm/bulma@0.9.0/css/bulma.min.css"
     />
     <link data-trunk rel="sass" href="index.scss" />
+    <link data-trunk rel="rust" data-cargo-features="csr" />
   </head>
 
   <body></body>

examples/function_router/src/main.rs

@@ -9,5 +9,6 @@ pub use app::*;
 fn main() {
     #[cfg(target_arch = "wasm32")]
     wasm_logger::init(wasm_logger::Config::new(log::Level::Trace));
-    yew::start_app::<App>();
+    #[cfg(feature = "render")]
+    yew::Renderer::<App>::new().render();
 }

examples/function_todomvc/Cargo.toml

@@ -10,7 +10,7 @@ serde = { version = "1.0", features = ["derive"] }
 strum = "0.24"
 strum_macros = "0.24"
 gloo = "0.6"
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 
 [dependencies.web-sys]
 version = "0.3"

examples/function_todomvc/src/main.rs

@@ -145,5 +145,5 @@ fn app() -> Html {
 }
 
 fn main() {
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/futures/Cargo.toml

@@ -9,7 +9,7 @@ license = "MIT OR Apache-2.0"
 pulldown-cmark = { version = "0.9", default-features = false }
 wasm-bindgen = "0.2"
 wasm-bindgen-futures = "0.4"
-yew = { path = "../../packages/yew", features = ["tokio"] }
+yew = { path = "../../packages/yew", features = ["tokio", "csr"] }
 gloo-utils = "0.1"
 
 [dependencies.web-sys]

examples/futures/src/main.rs

@@ -128,5 +128,5 @@ impl Component for App {
 }
 
 fn main() {
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/game_of_life/Cargo.toml

@@ -14,5 +14,5 @@ getrandom = { version = "0.2", features = ["js"] }
 log = "0.4"
 rand = "0.8"
 wasm-logger = "0.2"
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 gloo-timers = "0.2"

examples/game_of_life/src/main.rs

@@ -226,5 +226,5 @@ fn wrap(coord: isize, range: isize) -> usize {
 fn main() {
     wasm_logger::init(wasm_logger::Config::default());
     log::trace!("Initializing yew...");
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/inner_html/Cargo.toml

@@ -6,7 +6,7 @@ edition = "2021"
 license = "MIT OR Apache-2.0"
 
 [dependencies]
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 gloo-utils = "0.1"
 
 [dependencies.web-sys]

examples/inner_html/src/main.rs

@@ -26,5 +26,5 @@ impl Component for App {
 }
 
 fn main() {
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/js_callback/Cargo.toml

@@ -7,7 +7,7 @@ license = "MIT OR Apache-2.0"
 
 [dependencies]
 wasm-bindgen = "0.2"
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 
 [dependencies.web-sys]
 version = "0.3"

examples/js_callback/src/main.rs

@@ -73,5 +73,5 @@ impl Component for App {
 }
 
 fn main() {
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/keyed_list/Cargo.toml

@@ -12,7 +12,7 @@ instant = { version = "0.1", features = ["wasm-bindgen"] }
 log = "0.4"
 rand = "0.8"
 wasm-logger = "0.2"
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 
 [dependencies.web-sys]
 version = "0.3"

examples/keyed_list/src/main.rs

@@ -279,5 +279,5 @@ impl App {
 
 fn main() {
     wasm_logger::init(wasm_logger::Config::new(log::Level::Trace));
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/mount_point/Cargo.toml

@@ -7,7 +7,7 @@ license = "MIT OR Apache-2.0"
 
 [dependencies]
 wasm-bindgen = "0.2"
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 gloo-utils = "0.1"
 
 [dependencies.web-sys]

examples/mount_point/src/main.rs

@@ -73,5 +73,5 @@ fn main() {
 
     body.append_child(&mount_point).unwrap();
 
-    yew::start_app_in_element::<App>(mount_point);
+    yew::Renderer::<App>::with_root(mount_point).render();
 }

examples/nested_list/Cargo.toml

@@ -8,4 +8,4 @@ license = "MIT OR Apache-2.0"
 [dependencies]
 log = "0.4"
 wasm-logger = "0.2"
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }

examples/nested_list/src/main.rs

@@ -63,5 +63,5 @@ impl fmt::Display for Hovered {
 
 fn main() {
     wasm_logger::init(wasm_logger::Config::default());
-    yew::start_app::<app::App>();
+    yew::Renderer::<app::App>::new().render();
 }

examples/node_refs/Cargo.toml

@@ -6,5 +6,5 @@ edition = "2021"
 license = "MIT OR Apache-2.0"
 
 [dependencies]
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 web-sys = { version = "0.3", features = ["HtmlElement", "HtmlInputElement", "Node"] }

examples/node_refs/src/main.rs

@@ -77,5 +77,5 @@ impl Component for App {
 }
 
 fn main() {
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/password_strength/Cargo.toml

@@ -6,7 +6,7 @@ edition = "2021"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 [dependencies]
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 zxcvbn = "2.1.2, <2.2.0"
 js-sys = "0.3.46"
 web-sys = { version = "0.3", features = ["Event","EventTarget","InputEvent"] }

examples/password_strength/src/main.rs

@@ -8,5 +8,5 @@ mod password;
 use app::App;
 
 fn main() {
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/portals/Cargo.toml

@@ -6,7 +6,7 @@ edition = "2021"
 license = "MIT OR Apache-2.0"
 
 [dependencies]
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 gloo-utils = "0.1"
 wasm-bindgen = "0.2"
 

examples/portals/src/main.rs

@@ -102,5 +102,5 @@ impl Component for App {
 }
 
 fn main() {
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/router/Cargo.toml

@@ -11,7 +11,7 @@ log = "0.4"
 getrandom = { version = "0.2", features = ["js"] }
 rand = { version = "0.8", features = ["small_rng"] }
 wasm-logger = "0.2"
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 yew-router = { path = "../../packages/yew-router" }
 serde = { version = "1.0", features = ["derive"] }
 lazy_static = "1.4.0"

examples/router/src/main.rs

@@ -147,5 +147,5 @@ fn switch(routes: &Route) -> Html {
 
 fn main() {
     wasm_logger::init(wasm_logger::Config::new(log::Level::Trace));
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/suspense/Cargo.toml

@@ -7,7 +7,7 @@ license = "MIT OR Apache-2.0"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-yew = { path = "../../packages/yew", features = ["tokio"] }
+yew = { path = "../../packages/yew", features = ["tokio", "csr"] }
 gloo-timers = { version = "0.2.2", features = ["futures"] }
 wasm-bindgen-futures = "0.4"
 wasm-bindgen = "0.2"

examples/suspense/src/main.rs

@@ -56,5 +56,5 @@ fn app() -> Html {
 }
 
 fn main() {
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }

examples/timer/Cargo.toml

@@ -6,7 +6,7 @@ edition = "2021"
 license = "MIT OR Apache-2.0"
 
 [dependencies]
-yew = { path = "../../packages/yew" }
+yew = { path = "../../packages/yew", features = ["csr"] }
 js-sys = "0.3"
 gloo = "0.6"
 wasm-bindgen = "0.2"

examples/timer/src/main.rs

@@ -150,5 +150,5 @@ impl Component for App {
 }
 
 fn main() {
-    yew::start_app::<App>();
+    yew::Renderer::<App>::new().render();
 }