Make more service's methods static (yewstack#1382)

Author: jplatte

examples/file_upload/src/lib.rs

@@ -5,7 +5,6 @@ use yew::{html, ChangeData, Component, ComponentLink, Html, ShouldRender};
 
 pub struct Model {
     link: ComponentLink<Model>,
-    reader: ReaderService,
     tasks: Vec<ReaderTask>,
     files: Vec<String>,
     by_chunks: bool,
@@ -26,7 +25,6 @@ impl Component for Model {
 
     fn create(_: Self::Properties, link: ComponentLink<Self>) -> Self {
         Model {
-            reader: ReaderService::new(),
             link,
             tasks: vec![],
             files: vec![],
@@ -49,10 +47,10 @@ impl Component for Model {
                     let task = {
                         if chunks {
                             let callback = self.link.callback(Msg::Chunk);
-                            self.reader.read_file_by_chunks(file, callback, 10).unwrap()
+                            ReaderService::read_file_by_chunks(file, callback, 10).unwrap()
                         } else {
                             let callback = self.link.callback(Msg::Loaded);
-                            self.reader.read_file(file, callback).unwrap()
+                            ReaderService::read_file(file, callback).unwrap()
                         }
                     };
                     self.tasks.push(task);

yew-stdweb/examples/file_upload/src/lib.rs

@@ -5,7 +5,6 @@ use yew::{html, ChangeData, Component, ComponentLink, Html, ShouldRender};
 
 pub struct Model {
     link: ComponentLink<Model>,
-    reader: ReaderService,
     tasks: Vec<ReaderTask>,
     files: Vec<String>,
     by_chunks: bool,
@@ -26,7 +25,6 @@ impl Component for Model {
 
     fn create(_: Self::Properties, link: ComponentLink<Self>) -> Self {
         Model {
-            reader: ReaderService::new(),
             link,
             tasks: vec![],
             files: vec![],
@@ -53,10 +51,10 @@ impl Component for Model {
                     let task = {
                         if chunks {
                             let callback = self.link.callback(Msg::Chunk);
-                            self.reader.read_file_by_chunks(file, callback, 10).unwrap()
+                            ReaderService::read_file_by_chunks(file, callback, 10).unwrap()
                         } else {
                             let callback = self.link.callback(Msg::Loaded);
-                            self.reader.read_file(file, callback).unwrap()
+                            ReaderService::read_file(file, callback).unwrap()
                         }
                     };
                     self.tasks.push(task);

yew/src/services/reader/std_web.rs

@@ -25,17 +25,8 @@ fn new_file_reader() -> Result<FileReader, &'static str> {
 }
 
 impl ReaderService {
-    /// Creates a new service instance connected to `App` by provided `sender`.
-    pub fn new() -> Self {
-        Self {}
-    }
-
     /// Reads all bytes from a file and returns them with a callback.
-    pub fn read_file(
-        &mut self,
-        file: File,
-        callback: Callback<FileData>,
-    ) -> Result<ReaderTask, &str> {
+    pub fn read_file(file: File, callback: Callback<FileData>) -> Result<ReaderTask, &'static str> {
         let file_reader = new_file_reader()?;
         let reader = file_reader.clone();
         let name = file.name();
@@ -59,11 +50,10 @@ impl ReaderService {
 
     /// Reads data chunks from a file and returns them with a callback.
     pub fn read_file_by_chunks(
-        &mut self,
         file: File,
         callback: Callback<Option<FileChunk>>,
         chunk_size: usize,
-    ) -> Result<ReaderTask, &str> {
+    ) -> Result<ReaderTask, &'static str> {
         let file_reader = new_file_reader()?;
         let name = file.name();
         let mut position = 0;

yew/src/services/reader/web_sys.rs

@@ -12,13 +12,8 @@ use js_sys::Uint8Array;
 use std::cmp;
 
 impl ReaderService {
-    /// Creates a new service instance connected to `App` by provided `sender`.
-    pub fn new() -> Self {
-        Self {}
-    }
-
     /// Reads all bytes from a file and returns them with a callback.
-    pub fn read_file(&mut self, file: File, callback: Callback<FileData>) -> Result<ReaderTask> {
+    pub fn read_file(file: File, callback: Callback<FileData>) -> Result<ReaderTask> {
         let file_reader = FileReader::new().map_err(|_| anyhow!("couldn't acquire file reader"))?;
         let reader = file_reader.clone();
         let name = file.name();
@@ -42,7 +37,6 @@ impl ReaderService {
 
     /// Reads data chunks from a file and returns them with a callback.
     pub fn read_file_by_chunks(
-        &mut self,
         file: File,
         callback: Callback<Option<FileChunk>>,
         chunk_size: usize,

yew/src/services/resize.rs

@@ -57,13 +57,8 @@ impl WindowDimensions {
 }
 
 impl ResizeService {
-    /// Creates a new ResizeService.
-    pub fn new() -> ResizeService {
-        ResizeService {}
-    }
-
     /// Register a callback that will be called when the browser window resizes.
-    pub fn register(&mut self, callback: Callback<WindowDimensions>) -> ResizeTask {
+    pub fn register(callback: Callback<WindowDimensions>) -> ResizeTask {
         let callback =
             move |#[cfg(feature = "web_sys")] _event: &Event,
                   #[cfg(feature = "std_web")] _event: ResizeEvent| {