Skip to content

Commit 386233c

Browse files
committed
Fix workflow waring message
1 parent 4968e9a commit 386233c

File tree

6 files changed

+11
-14
lines changed

6 files changed

+11
-14
lines changed

.github/workflows/publish-release.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -83,20 +83,20 @@ jobs:
8383
- uses: actions/checkout@v3
8484
with:
8585
ref: main
86-
- name: Set up Python 3.8
86+
- name: Set up Python 3.12
8787
uses: actions/setup-python@v4
8888
with:
89-
python-version: '3.8'
89+
python-version: '3.12'
9090
- name: Install dependencies
9191
run: |
9292
python -m pip install --upgrade pip
9393
pip install .
94-
pip install pyinstaller==5.9.0
94+
pip install pyinstaller
9595
- name: Build with pyinstaller for ${{matrix.TARGET}}
9696
run: ${{matrix.CMD_BUILD}}
9797
- name: Upload Release Asset
9898
id: upload-release-asset
99-
uses: actions/upload-release-asset@v1.0.1
99+
uses: softprops/action-gh-release@v1
100100
env:
101101
GITHUB_TOKEN: ${{ secrets.TOKEN }}
102102
with:
@@ -114,7 +114,7 @@ jobs:
114114
- name: Set up Python
115115
uses: actions/setup-python@v4
116116
with:
117-
python-version: '3.8'
117+
python-version: '3.12'
118118
- name: Install dependencies
119119
run: |
120120
python -m pip install --upgrade pip

.github/workflows/pull-request.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
runs-on: ubuntu-latest
1717
strategy:
1818
matrix:
19-
python-version: [3.8]
19+
python-version: [3.12.x]
2020

2121
steps:
2222
- uses: actions/checkout@v3
@@ -37,13 +37,13 @@ jobs:
3737
runs-on: windows-latest
3838
strategy:
3939
matrix:
40-
python-version: [3.8]
40+
python-version: [3.12.x]
4141
steps:
4242
- uses: actions/checkout@v3
43-
- name: Set up Python 3.8
43+
- name: Set up Python 3.12
4444
uses: actions/setup-python@v4
4545
with:
46-
python-version: '3.8'
46+
python-version: '3.12.x'
4747
- name: Install & Run
4848
run: |
4949
python -m pip install --upgrade pip

requirements-dev.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
pyinstaller==5.9.0
1+
pyinstaller==6.0.0
22
tox
33
pytest
44
pytest-cov
55
pytest-flake8
66
pytest-xdist
7-
flake8==3.9.2
7+
flake8

src/fosslight_binary/_binary_dao.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ def get_list_by_using_query(sql_query, columns):
142142

143143

144144
def disconnect_lge_bin_db():
145-
global conn, cur
146145
try:
147146
cur.close()
148147
conn.close()

src/fosslight_binary/binary_analysis.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,6 @@ def check_binary(file_with_path):
340340

341341

342342
def error_occured(error_msg, exit=False, result_log={}, mode="Normal mode"):
343-
global _error_logs
344343
_error_logs.append(error_msg)
345344
if exit:
346345
print_result_log(mode, success=False, result_log=result_log)

src/fosslight_binary/cli.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ def paginate_file(file_path):
3232

3333

3434
def main():
35-
global windows
3635
path_to_find_bin = ""
3736
path_to_exclude = []
3837
output_dir = ""

0 commit comments

Comments
 (0)