Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: PSLabSensor Activity decoupled from fragments #2110

Merged
merged 2 commits into from
May 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@

import io.pslab.R;
import io.pslab.activity.AccelerometerActivity;
import io.pslab.interfaces.OperationCallback;
import io.pslab.models.AccelerometerData;
import io.pslab.models.SensorDataBlock;
import io.pslab.others.CSVDataLine;
Expand All @@ -47,7 +48,7 @@
* Created by Kunal on 18-12-18
*/

public class AccelerometerDataFragment extends Fragment {
public class AccelerometerDataFragment extends Fragment implements OperationCallback {

private static final CSVDataLine CSV_HEADER = new CSVDataLine()
.add("Timestamp")
Expand Down Expand Up @@ -267,6 +268,7 @@ public void run() {
}, 0, timeGap);
}

@Override
public void playData() {
resetInstrumentData();
accelerometerSensor.startedPlay = true;
Expand All @@ -284,6 +286,7 @@ public void playData() {
}
}

@Override
public void stopData() {
if (graphTimer != null) {
graphTimer.cancel();
Expand All @@ -300,6 +303,7 @@ public void stopData() {
accelerometerSensor.invalidateOptionsMenu();
}

@Override
public void saveGraph() {
accelerometerSensor.csvLogger.prepareLogFile();
accelerometerSensor.csvLogger.writeMetaData(getResources().getString(R.string.accelerometer));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
import io.pslab.communication.ScienceLab;
import io.pslab.communication.peripherals.I2C;
import io.pslab.communication.sensors.BMP180;
import io.pslab.interfaces.OperationCallback;
import io.pslab.models.BaroData;
import io.pslab.models.PSLabSensor;
import io.pslab.models.SensorDataBlock;
Expand All @@ -64,7 +65,7 @@
* Created by Padmal on 12/13/18.
*/

public class BaroMeterDataFragment extends Fragment {
public class BaroMeterDataFragment extends Fragment implements OperationCallback {

private static final CSVDataLine CSV_HEADER = new CSVDataLine()
.add("Timestamp")
Expand Down Expand Up @@ -331,6 +332,7 @@ public void run() {
}, 0, timeGap);
}

@Override
public void playData() {
resetInstrumentData();
baroSensor.startedPlay = true;
Expand All @@ -348,6 +350,7 @@ public void playData() {
}
}

@Override
public void stopData() {
if (graphTimer != null) {
graphTimer.cancel();
Expand All @@ -362,6 +365,7 @@ public void stopData() {
baroSensor.invalidateOptionsMenu();
}

@Override
public void saveGraph() {
baroSensor.csvLogger.prepareLogFile();
baroSensor.csvLogger.writeMetaData(getResources().getString(R.string.baro_meter));
Expand Down
6 changes: 5 additions & 1 deletion app/src/main/java/io/pslab/fragment/CompassDataFragment.java
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import io.pslab.activity.CompassActivity;
import io.pslab.communication.ScienceLab;
import io.pslab.communication.peripherals.I2C;
import io.pslab.interfaces.OperationCallback;
import io.pslab.models.CompassData;
import io.pslab.models.SensorDataBlock;
import io.pslab.others.CSVDataLine;
Expand All @@ -48,7 +49,7 @@
import static android.content.Context.SENSOR_SERVICE;
import static io.pslab.others.CSVLogger.CSV_DIRECTORY;

public class CompassDataFragment extends Fragment {
public class CompassDataFragment extends Fragment implements OperationCallback {

private static final CSVDataLine CSV_HEADER = new CSVDataLine()
.add("Timestamp")
Expand Down Expand Up @@ -246,6 +247,7 @@ public void onResume() {
}
}

@Override
public void saveGraph() {
compassActivity.csvLogger.prepareLogFile();
compassActivity.csvLogger.writeMetaData(getResources().getString(R.string.compass));
Expand Down Expand Up @@ -382,6 +384,7 @@ public void run() {
}, 0, timeGap);
}

@Override
public void playData() {
resetInstrumentData();
compassActivity.startedPlay = true;
Expand All @@ -399,6 +402,7 @@ public void playData() {
}
}

@Override
public void stopData() {
if (graphTimer != null) {
graphTimer.cancel();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import io.pslab.R;
import io.pslab.activity.DustSensorActivity;
import io.pslab.communication.ScienceLab;
import io.pslab.interfaces.OperationCallback;
import io.pslab.models.DustSensorData;
import io.pslab.models.GasSensorData;
import io.pslab.models.SensorDataBlock;
Expand All @@ -50,7 +51,7 @@

import static io.pslab.others.CSVLogger.CSV_DIRECTORY;

public class DustSensorDataFragment extends Fragment {
public class DustSensorDataFragment extends Fragment implements OperationCallback {

private static final CSVDataLine CSV_HEADER =
new CSVDataLine()
Expand Down Expand Up @@ -260,6 +261,7 @@ public void run() {
}, 0, timeGap);
}

@Override
public void playData() {
resetInstrumentData();
dustSensorActivity.startedPlay = true;
Expand All @@ -277,6 +279,7 @@ public void playData() {
}
}

@Override
public void stopData() {
if (graphTimer != null) {
graphTimer.cancel();
Expand All @@ -291,6 +294,7 @@ public void stopData() {
dustSensorActivity.invalidateOptionsMenu();
}

@Override
public void saveGraph() {
dustSensorActivity.csvLogger.prepareLogFile();
dustSensorActivity.csvLogger.writeMetaData(getResources().getString(R.string.gas_sensor));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import io.pslab.R;
import io.pslab.activity.GasSensorActivity;
import io.pslab.communication.ScienceLab;
import io.pslab.interfaces.OperationCallback;
import io.pslab.models.GasSensorData;
import io.pslab.models.SensorDataBlock;
import io.pslab.others.CSVDataLine;
Expand All @@ -49,7 +50,7 @@

import static io.pslab.others.CSVLogger.CSV_DIRECTORY;

public class GasSensorDataFragment extends Fragment {
public class GasSensorDataFragment extends Fragment implements OperationCallback {

private static final CSVDataLine CSV_HEADER = new CSVDataLine()
.add("Timestamp")
Expand Down Expand Up @@ -238,6 +239,7 @@ public void run() {
}, 0, timeGap);
}

@Override
public void playData() {
resetInstrumentData();
gasSensorActivity.startedPlay = true;
Expand All @@ -255,6 +257,7 @@ public void playData() {
}
}

@Override
public void stopData() {
if (graphTimer != null) {
graphTimer.cancel();
Expand All @@ -269,6 +272,7 @@ public void stopData() {
gasSensorActivity.invalidateOptionsMenu();
}

@Override
public void saveGraph() {
gasSensorActivity.csvLogger.prepareLogFile();
gasSensorActivity.csvLogger.writeMetaData(getResources().getString(R.string.gas_sensor));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@

import io.pslab.R;
import io.pslab.activity.GyroscopeActivity;
import io.pslab.interfaces.OperationCallback;
import io.pslab.models.GyroData;
import io.pslab.models.SensorDataBlock;
import io.pslab.others.CSVDataLine;
Expand All @@ -45,7 +46,7 @@
import static android.content.Context.SENSOR_SERVICE;
import static io.pslab.others.CSVLogger.CSV_DIRECTORY;

public class GyroscopeDataFragment extends Fragment {
public class GyroscopeDataFragment extends Fragment implements OperationCallback {

private static final CSVDataLine CSV_HEADER = new CSVDataLine()
.add("Timestamp")
Expand Down Expand Up @@ -272,6 +273,7 @@ public void run() {
}, 0, timeGap);
}

@Override
public void playData() {
resetInstrumentData();
gyroSensor.startedPlay = true;
Expand All @@ -289,6 +291,7 @@ public void playData() {
}
}

@Override
public void stopData() {
if (graphTimer != null) {
graphTimer.cancel();
Expand All @@ -305,6 +308,7 @@ public void stopData() {
gyroSensor.invalidateOptionsMenu();
}

@Override
public void saveGraph() {
gyroSensor.csvLogger.prepareLogFile();
gyroSensor.csvLogger.writeMetaData(getResources().getString(R.string.gyroscope));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
import io.pslab.communication.peripherals.I2C;
import io.pslab.communication.sensors.BH1750;
import io.pslab.communication.sensors.TSL2561;
import io.pslab.interfaces.OperationCallback;
import io.pslab.models.LuxData;
import io.pslab.models.PSLabSensor;
import io.pslab.models.SensorDataBlock;
Expand All @@ -63,7 +64,7 @@
* Created by Padmal on 11/2/18.
*/

public class LuxMeterDataFragment extends Fragment {
public class LuxMeterDataFragment extends Fragment implements OperationCallback {

private static final CSVDataLine CSV_HEADER =
new CSVDataLine()
Expand Down Expand Up @@ -298,6 +299,7 @@ public void run() {
}, 0, timeGap);
}

@Override
public void stopData() {
if (graphTimer != null) {
graphTimer.cancel();
Expand All @@ -312,6 +314,7 @@ public void stopData() {
luxSensor.invalidateOptionsMenu();
}

@Override
public void playData() {
resetInstrumentData();
luxSensor.startedPlay = true;
Expand All @@ -329,6 +332,7 @@ public void playData() {
}
}

@Override
public void saveGraph() {
luxSensor.csvLogger.prepareLogFile();
luxSensor.csvLogger.writeMetaData(getResources().getString(R.string.lux_meter));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import butterknife.Unbinder;
import io.pslab.R;
import io.pslab.activity.SoundMeterActivity;
import io.pslab.interfaces.OperationCallback;
import io.pslab.models.PSLabSensor;
import io.pslab.models.SensorDataBlock;
import io.pslab.models.SoundData;
Expand All @@ -51,7 +52,7 @@
/**
* @author reckoner1429
*/
public class SoundMeterDataFragment extends Fragment {
public class SoundMeterDataFragment extends Fragment implements OperationCallback {

public static final String TAG = "SoundMeterFragment";
private static final CSVDataLine CSV_HEADER =
Expand Down Expand Up @@ -284,6 +285,7 @@ private void updateChart(short[] buffer) {
/**
* Method to play data which was previously recorded
*/
@Override
public void playData() {
CustomSnackBar.showSnackBar(getActivity().findViewById(android.R.id.content), getString(R.string.in_progress),
null, null, Snackbar.LENGTH_SHORT);
Expand All @@ -296,6 +298,7 @@ public void playData() {
/**
* Method to stop playing the previously recorded data
*/
@Override
public void stopData() {
CustomSnackBar.showSnackBar(getActivity().findViewById(android.R.id.content), getString(R.string.in_progress),
null, null, Snackbar.LENGTH_SHORT);
Expand Down Expand Up @@ -347,6 +350,7 @@ private void writeLog(long timestamp, float dB) {
}
}

@Override
public void saveGraph() {
soundMeter.csvLogger.prepareLogFile();
soundMeter.csvLogger.writeMetaData(getResources().getString(R.string.lux_meter));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
import io.pslab.communication.ScienceLab;
import io.pslab.communication.peripherals.I2C;
import io.pslab.communication.sensors.SHT21;
import io.pslab.interfaces.OperationCallback;
import io.pslab.models.PSLabSensor;
import io.pslab.models.SensorDataBlock;
import io.pslab.models.ThermometerData;
Expand All @@ -58,7 +59,7 @@
import static android.content.Context.SENSOR_SERVICE;
import static io.pslab.others.CSVLogger.CSV_DIRECTORY;

public class ThermometerDataFragment extends Fragment {
public class ThermometerDataFragment extends Fragment implements OperationCallback {

private static final String TEMPERATURE = "temperature";
private static final CSVDataLine CSV_HEADER = new CSVDataLine()
Expand Down Expand Up @@ -297,6 +298,7 @@ public void run() {
}, 0, timeGap);
}

@Override
public void stopData() {
if (graphTimer != null) {
graphTimer.cancel();
Expand All @@ -311,6 +313,7 @@ public void stopData() {
thermoSensor.invalidateOptionsMenu();
}

@Override
public void playData() {
resetInstrumentData();
thermoSensor.startedPlay = true;
Expand All @@ -328,6 +331,7 @@ public void playData() {
}
}

@Override
public void saveGraph() {
thermoSensor.csvLogger.prepareLogFile();
thermoSensor.csvLogger.writeMetaData(getResources().getString(R.string.thermometer));
Expand Down
10 changes: 10 additions & 0 deletions app/src/main/java/io/pslab/interfaces/OperationCallback.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package io.pslab.interfaces;

/**
* created by VIKAS9899 on 14/05/2020
*/
public interface OperationCallback {
void playData();
void stopData();
void saveGraph();
}
Loading