-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHT21 : Temperature and Humidity Meter UI Improvement #893
Comments
You can research more and post some more pictures. There are lot of mobile applications developed to measure temperature and humidity using a sensor. You can adjust your UI accordingly. |
@yatri1609 how is the progress? Can we add both humidity and temperature data in the same window without using two tabs just like in the app suggested by @Vikum94 ? |
@CloudyPadmal Ya I think we can do that and then down we can show buttons which will open up graphs or we can make the icons clickable. |
@CloudyPadmal Do we need to implement the color as per the the temperature and humidity or just put the icons and a mark on the scale? |
Design with the app theme would be great! |
@CloudyPadmal Implementation of the layout which @Vikum94 suggested is getting a bit difficult with both humidity and temperature on the same screen so can we implement tab as we need graphs and other features too ? |
Can I know why is it difficult to implement? What problems did you faced? If you faced problems displaying 2 data in one graph, do ask any one who did oscilloscope to assist. |
@cweitat Ohk the difficulty was in implementing the thermometer and the water droplet so ya I guess other than that I would be able to handle it now. I'll submit a mockup for the same soon |
@yatri1609 what's the progress for this? |
I guess Harsh was also implementing the temperature and humidity sensor according to the updated sensor list. I have worked half way through this from my part. |
@cweitat I'll submit suggested layout by tomorrow |
@yatri1609 Are you working on it halfway already? it is okay to implement other sensors also. Doesn't necessarily need to be DHT11. The more sensors the device can work with the better |
@cweitat ohk I'll continue with this but it will be better to have a same UI for both as both measures temperature and humidity. And also in the sensors sheet DHT11 was there so I thought maybe before we got on board the SHT21 sensor would have been removed due to some reasons. |
@cweitat I'm almost done with the UI which will be similar to the Lux meter and Barometer with just single graph showing both the data in it. |
@yatri1609 do you have screenshots? so of course the ideal situation is that the device is able to automatically detect DHT11 or SHT21 |
Is this kind of layout fine, with 2 meters showing temperature and humidity both? And then chart to show the graphs? @cweitat @CloudyPadmal |
Please check out #1349 |
@cweitat What do you think about this ? I had already suggested earlier |
@yatri1609 Don't need the section boxes. The previous design is good enough. Let's finalise the standard design to use first before proceeding |
@cweitat Yes sure, I'm currently stopping my working on this. |
There is a UI available with mentioned min max values with value changes |
Actual Behaviour
Right now only the Temperature and Humidity are recorded and plotted on the graph. I would like to add maximum and minimum for the same and also enable units change from Celsius to Fahrenheit and vice versa.
Including some UI improvements.
Expected Behaviour
This is the kind of Thermo Hygrometers available in the market. So I would like to develop similar UI kind of UI with buttons for changing a the units and implementing maximum and minimum.
I would be uploading the new UI soon.
Steps to reproduce it
Check layout [file] (https://github.com/fossasia/pslab-android/blob/development/app/src/main/res/layout/sensor_sht21.xml)
LogCat for the issue
Not applicable
Screenshots of the issue
Would you like to work on the issue?
Yes
The text was updated successfully, but these errors were encountered: