Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHT21 : Temperature and Humidity Meter UI Improvement #893

Closed
yatri1609 opened this issue May 21, 2018 · 24 comments
Closed

SHT21 : Temperature and Humidity Meter UI Improvement #893

yatri1609 opened this issue May 21, 2018 · 24 comments
Assignees
Labels
Feature New addition to the existing app Instrument: Sensors
Milestone

Comments

@yatri1609
Copy link
Contributor

Actual Behaviour
Right now only the Temperature and Humidity are recorded and plotted on the graph. I would like to add maximum and minimum for the same and also enable units change from Celsius to Fahrenheit and vice versa.
Including some UI improvements.

Expected Behaviour
screenshot-2018-5-21 mextech m288cthw digital thermo hygrometer with indoor outdoor temperature amazon in industrial scient
This is the kind of Thermo Hygrometers available in the market. So I would like to develop similar UI kind of UI with buttons for changing a the units and implementing maximum and minimum.
I would be uploading the new UI soon.

Steps to reproduce it
Check layout [file] (https://github.com/fossasia/pslab-android/blob/development/app/src/main/res/layout/sensor_sht21.xml)

LogCat for the issue
Not applicable

Screenshots of the issue
screenshot from 2018-05-21 20-04-42
screenshot from 2018-05-21 20-05-20

Would you like to work on the issue?
Yes

@yatri1609
Copy link
Contributor Author

screenshot from 2018-05-22 12-10-28
screenshot from 2018-05-22 12-10-54

This is what I'm planning to do both for Humidity and Temperature. Please review it and tell me if any add-ons or changes are needed.

@Vikum94
Copy link
Contributor

Vikum94 commented May 22, 2018

You can research more and post some more pictures. There are lot of mobile applications developed to measure temperature and humidity using a sensor. You can adjust your UI accordingly.

Check this

image

@yatri1609
Copy link
Contributor Author

sht21 svg
What do you think about this?

@CloudyPadmal
Copy link
Collaborator

@yatri1609 how is the progress? Can we add both humidity and temperature data in the same window without using two tabs just like in the app suggested by @Vikum94 ?

@yatri1609
Copy link
Contributor Author

@CloudyPadmal Ya I think we can do that and then down we can show buttons which will open up graphs or we can make the icons clickable.

@yatri1609
Copy link
Contributor Author

@CloudyPadmal Do we need to implement the color as per the the temperature and humidity or just put the icons and a mark on the scale?

@CloudyPadmal
Copy link
Collaborator

Design with the app theme would be great!

@yatri1609
Copy link
Contributor Author

@CloudyPadmal Implementation of the layout which @Vikum94 suggested is getting a bit difficult with both humidity and temperature on the same screen so can we implement tab as we need graphs and other features too ?

@mariobehling mariobehling added the Feature New addition to the existing app label Jun 21, 2018
@cweitat
Copy link
Contributor

cweitat commented Jul 9, 2018

Can I know why is it difficult to implement? What problems did you faced? If you faced problems displaying 2 data in one graph, do ask any one who did oscilloscope to assist.
Some graphics like the thermometer and the water droplet sign can be excluded. Both temp and humidity should be in the same chart with different line colours.
Temperature font size doesn't need to be so big. Have a look at Lux Meter. That font size is good enough. I'm sure you can handle the design.

@yatri1609
Copy link
Contributor Author

@cweitat Ohk the difficulty was in implementing the thermometer and the water droplet so ya I guess other than that I would be able to handle it now. I'll submit a mockup for the same soon

@cweitat
Copy link
Contributor

cweitat commented Aug 8, 2018

@yatri1609 what's the progress for this?

@yatri1609
Copy link
Contributor Author

I guess Harsh was also implementing the temperature and humidity sensor according to the updated sensor list. I have worked half way through this from my part.

@yatri1609
Copy link
Contributor Author

@cweitat I'll submit suggested layout by tomorrow

@yatri1609
Copy link
Contributor Author

@cweitat I guess the temperature and humidity sensor is now DHT11 #1172 rather than SHT21 so I'm not working on this.

@cweitat
Copy link
Contributor

cweitat commented Aug 9, 2018

@yatri1609 Are you working on it halfway already? it is okay to implement other sensors also. Doesn't necessarily need to be DHT11. The more sensors the device can work with the better

@yatri1609
Copy link
Contributor Author

yatri1609 commented Aug 9, 2018

@cweitat ohk I'll continue with this but it will be better to have a same UI for both as both measures temperature and humidity. And also in the sensors sheet DHT11 was there so I thought maybe before we got on board the SHT21 sensor would have been removed due to some reasons.

@yatri1609
Copy link
Contributor Author

@cweitat I'm almost done with the UI which will be similar to the Lux meter and Barometer with just single graph showing both the data in it.

@cweitat
Copy link
Contributor

cweitat commented Aug 9, 2018

@yatri1609 do you have screenshots? so of course the ideal situation is that the device is able to automatically detect DHT11 or SHT21

@yatri1609
Copy link
Contributor Author

Is this kind of layout fine, with 2 meters showing temperature and humidity both? And then chart to show the graphs? @cweitat @CloudyPadmal

@cweitat
Copy link
Contributor

cweitat commented Aug 9, 2018

Please check out #1349

@yatri1609
Copy link
Contributor Author

@cweitat What do you think about this ? I had already suggested earlier

@cweitat
Copy link
Contributor

cweitat commented Aug 9, 2018

@yatri1609 Don't need the section boxes. The previous design is good enough. Let's finalise the standard design to use first before proceeding

@yatri1609
Copy link
Contributor Author

@cweitat Yes sure, I'm currently stopping my working on this.

@CloudyPadmal
Copy link
Collaborator

There is a UI available with mentioned min max values with value changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New addition to the existing app Instrument: Sensors
Projects
None yet
Development

No branches or pull requests

5 participants