Fix #2510 scroll issue in favourite section (#2720)

Author: sparrow007

app/src/main/java/org/fossasia/phimpme/gallery/activities/LFMainActivity.java

@@ -97,6 +97,7 @@
 import org.fossasia.phimpme.gallery.data.providers.StorageProvider;
 import org.fossasia.phimpme.gallery.util.Affix;
 import org.fossasia.phimpme.gallery.util.AlertDialogsHelper;
+import org.fossasia.phimpme.gallery.util.CustomNestedView;
 import org.fossasia.phimpme.gallery.util.ContentHelper;
 import org.fossasia.phimpme.gallery.util.Measure;
 import org.fossasia.phimpme.gallery.util.PreferenceUtil;
@@ -201,6 +202,8 @@ public class LFMainActivity extends SharedMediaActivity {
 
     private SearchView searchView;
 
+    @BindView(R.id.nestedView)
+    protected CustomNestedView nestedView;
     @BindView(R.id.toolbar)
     protected Toolbar toolbar;
     @BindView(R.id.swipeRefreshLayout)
@@ -1713,21 +1716,23 @@ private void checkNothing() {
     private void checkNothingFavourites() {
         nothingToShow.setTextColor(getTextColor());
         nothingToShow.setText(R.string.no_favourites_text);
-        nothingToShow.setVisibility((albumsMode && getAlbums().dispAlbums.size() == 0 && !fav_photos) || (!albumsMode && getAlbum
+        int shouldShow = (albumsMode && getAlbums().dispAlbums.size() == 0 && !fav_photos) || (!albumsMode && getAlbum
                 ().getMedia().size() == 0 && !fav_photos) || (fav_photos && favouriteslist.size() == 0) ? View
                 .VISIBLE : View
-                .GONE);
-        noFavMsg.setVisibility((albumsMode && getAlbums().dispAlbums.size() == 0 && !fav_photos) || (!albumsMode && getAlbum
-                ().getMedia().size() == 0 && !fav_photos) || (fav_photos && favouriteslist.size() == 0) ? View
-                .VISIBLE : View
-                .GONE);
+                .GONE;
+        nothingToShow.setVisibility(shouldShow);
+        noFavMsg.setVisibility(shouldShow);
         noFavMsg.setText(R.string.no_favourites_message);
         noFavMsg.setTextColor(getTextColor());
-        starImageView.setVisibility((albumsMode && getAlbums().dispAlbums.size() == 0 && !fav_photos) || (!albumsMode && getAlbum
-                ().getMedia().size() == 0 && !fav_photos) || (fav_photos && favouriteslist.size() == 0) ? View
-                .VISIBLE : View
-                .GONE);
+        starImageView.setVisibility(shouldShow);
         starImageView.setColorFilter(getPrimaryColor());
+        if (shouldShow == View.VISIBLE) {
+            showAppBar();
+            nestedView.setScrolling(false);
+            rvMedia.setNestedScrollingEnabled(false);
+
+        }
+
     }
 
 

app/src/main/java/org/fossasia/phimpme/gallery/util/CustomNestedView.java

@@ -0,0 +1,48 @@
+package org.fossasia.phimpme.gallery.util;
+
+import android.content.Context;
+import android.support.v4.widget.NestedScrollView;
+import android.util.AttributeSet;
+import android.view.MotionEvent;
+
+
+public class CustomNestedView extends NestedScrollView
+{
+    private boolean enableScrolling = true;
+
+    public CustomNestedView(Context context, AttributeSet attrs)
+    {
+        super(context, attrs);
+    }
+
+
+    public CustomNestedView(Context context, AttributeSet attrs, int defStyleAttr) {
+        super(context, attrs, defStyleAttr);
+    }
+
+
+    @Override
+    public boolean onInterceptTouchEvent(MotionEvent ev) {
+        if (scrollingEnabled()) {
+            return super.onInterceptTouchEvent(ev);
+        } else {
+            return false;
+        }
+    }
+    @Override
+    public boolean onTouchEvent(MotionEvent ev) {
+        if (scrollingEnabled()) {
+            return super.onTouchEvent(ev);
+        } else {
+            return false;
+        }
+    }
+
+
+    private boolean scrollingEnabled(){
+        return enableScrolling;
+    }
+    public void setScrolling(boolean enableScrolling) {
+        this.enableScrolling = enableScrolling;
+    }
+}

app/src/main/java/org/fossasia/phimpme/gallery/views/CustomScrollBarRecyclerView.java

@@ -15,7 +15,6 @@
 
 public class CustomScrollBarRecyclerView extends RecyclerView {
     private int scrollBarColor = Color.RED;
-
     public CustomScrollBarRecyclerView(Context context) {
         super(context);
     }
@@ -49,4 +48,15 @@ protected void onDrawVerticalScrollBar(Canvas canvas, Drawable scrollBar, int l,
         scrollBar.setBounds(l, t, r, b);
         scrollBar.draw(canvas);
     }
+
+    @Override
+    public boolean dispatchNestedPreScroll(int dx, int dy, int[] consumed, int[] offsetInWindow) {
+        boolean returnValue;
+        returnValue = super.dispatchNestedPreScroll(dx, dy, consumed, offsetInWindow);
+        if (offsetInWindow[1] != 0) {
+            offsetInWindow[1] = 0;
+        }
+        return returnValue;
+    }
+
 }

app/src/main/res/layout/activity_leafpic.xml

@@ -22,9 +22,10 @@
                 layout="@layout/toolbar" />
         </android.support.design.widget.AppBarLayout>
 
-        <android.support.v4.widget.NestedScrollView
+        <org.fossasia.phimpme.gallery.util.CustomNestedView
             android:layout_width="match_parent"
             android:layout_height="match_parent"
+            android:id="@+id/nestedView"
             android:fillViewport="true"
             app:layout_behavior="@string/appbar_scrolling_view_behavior">
 
@@ -113,7 +114,7 @@
                     </RelativeLayout>
                 </android.support.v4.widget.SwipeRefreshLayout>
             </FrameLayout>
-        </android.support.v4.widget.NestedScrollView>
+        </org.fossasia.phimpme.gallery.util.CustomNestedView>
 
         <include
             android:id="@+id/bottombar"