Skip to content

chore: improve error reporting and fix typos #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2020

Conversation

snitin315
Copy link
Member

SELF EXPLANATORY

@vercel
Copy link

vercel bot commented Mar 29, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/eventyay/open-event-frontend/qnoog3rwo
✅ Preview: https://open-event-frontend-git-fork-snitin315-typo.eventyay.now.sh

@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #4290 into development will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4290      +/-   ##
===============================================
- Coverage        21.87%   21.86%   -0.02%     
===============================================
  Files              461      461              
  Lines             4831     4835       +4     
  Branches             5        5              
===============================================
  Hits              1057     1057              
- Misses            3772     3776       +4     
  Partials             2        2              
Impacted Files Coverage Δ
...rollers/events/view/tickets/access-codes/create.js 0.00% <0.00%> (ø)
...ntrollers/events/view/tickets/access-codes/edit.js 0.00% <0.00%> (ø)
...llers/events/view/tickets/discount-codes/create.js 0.00% <0.00%> (ø)
...rollers/events/view/tickets/discount-codes/edit.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953d3a7...1e3cb95. Read the comment docs.

@iamareebjamal
Copy link
Member

iamareebjamal commented Mar 29, 2020

Please add proper console.error along with this

@snitin315 snitin315 changed the title chore: fix typos chore: improve error reporting and fix typos Mar 31, 2020
@iamareebjamal iamareebjamal merged commit b13614f into fossasia:development Mar 31, 2020
@snitin315 snitin315 deleted the typo branch March 31, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants