Summary: Add chaining RxJava

Fixes: #2116

Author: anhanh11001

app/src/main/java/org/fossasia/openevent/general/about/AboutEventViewModel.kt

@@ -25,7 +25,7 @@ class AboutEventViewModel(private val eventService: EventService, private val re
     val error: LiveData<String> = mutableError
 
     fun loadEvent(id: Long) {
-        if (id.equals(-1)) {
+        if (id == -1L) {
             mutableError.value = Resource().getString(R.string.error_fetching_event_message)
             return
         }

app/src/main/java/org/fossasia/openevent/general/auth/EditProfileViewModel.kt

@@ -3,6 +3,7 @@ package org.fossasia.openevent.general.auth
 import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.ViewModel
+import io.reactivex.Single
 import io.reactivex.disposables.CompositeDisposable
 import io.reactivex.rxkotlin.plusAssign
 import org.fossasia.openevent.general.utils.extensions.withDefaultSchedulers
@@ -37,43 +38,17 @@ class EditProfileViewModel(
      *  @param lastName updated lastName
      */
     fun updateProfile(firstName: String, lastName: String, details: String) {
-        if (encodedImage.isNullOrEmpty()) {
-            updateUser(null, firstName, lastName, details)
-            return
-        }
-        compositeDisposable += authService.uploadImage(UploadImage(encodedImage))
-            .withDefaultSchedulers()
-            .doOnSubscribe {
-                mutableProgress.value = true
-            }
-            .doFinally {
-                mutableProgress.value = false
-            }
-            .subscribe({
-                updateUser(it.url, firstName, lastName, details)
-                mutableMessage.value = resource.getString(R.string.image_upload_success_message)
-                Timber.d("Image uploaded ${it.url}")
-            }) {
-                mutableMessage.value = resource.getString(R.string.image_upload_error_message)
-                Timber.e(it, "Error uploading user!")
-            }
-    }
-
-    private fun updateUser(url: String?, firstName: String, lastName: String, details: String) {
         val id = authHolder.getId()
-        if (firstName.isEmpty() || lastName.isEmpty()) {
-            mutableMessage.value = resource.getString(R.string.provide_name_message)
-            return
-        }
-        compositeDisposable += authService.updateUser(
-            User(
-                id = id,
-                firstName = firstName,
-                lastName = lastName,
-                avatarUrl = url,
-                details = details
-            ), id
-        )
+        val user = User(id = id, firstName = firstName, lastName = lastName, avatarUrl = null, details = details)
+        val updateProfileObservable: Single<User> =
+            if (encodedImage.isNullOrEmpty())
+                authService.updateUser(user, id)
+            else
+                authService.uploadImage(UploadImage(encodedImage)).flatMap {
+                    authService.updateUser(user.copy(avatarUrl = it.url), id)
+                }
+
+        compositeDisposable += updateProfileObservable
             .withDefaultSchedulers()
             .doOnSubscribe {
                 mutableProgress.value = true

app/src/main/java/org/fossasia/openevent/general/auth/SignUpViewModel.kt

@@ -3,6 +3,7 @@ package org.fossasia.openevent.general.auth
 import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.ViewModel
+import io.reactivex.Single
 import io.reactivex.disposables.CompositeDisposable
 import io.reactivex.rxkotlin.plusAssign
 import org.fossasia.openevent.general.utils.extensions.withDefaultSchedulers
@@ -36,14 +37,19 @@ class SignUpViewModel(
     fun signUp(signUp: SignUp) {
         if (!isConnected()) return
 
-        compositeDisposable += authService.signUp(signUp)
-            .withDefaultSchedulers()
+        compositeDisposable += authService.signUp(signUp).flatMap {
+            email = signUp.email
+            password = signUp.password
+            authService.login(email.nullToEmpty(), password.nullToEmpty()).flatMap {
+                authService.getProfile()
+            }
+        }.withDefaultSchedulers()
             .doOnSubscribe {
                 mutableProgress.value = true
             }.doFinally {
                 mutableProgress.value = false
             }.subscribe({
-                login(signUp)
+                mutableLoggedIn.value = true
                 Timber.d("Success!")
             }, {
                 when {
@@ -57,37 +63,6 @@ class SignUpViewModel(
             })
     }
 
-    private fun login(signUp: SignUp) {
-        if (!isConnected()) return
-        email = signUp.email
-        password = signUp.password
-        compositeDisposable += authService.login(email.nullToEmpty(), password.nullToEmpty())
-            .withDefaultSchedulers()
-            .doOnSubscribe {
-                mutableProgress.value = true
-            }.doFinally {
-                mutableProgress.value = false
-            }.subscribe({
-                mutableLoggedIn.value = true
-                Timber.d("Success!")
-                fetchProfile()
-            }, {
-                mutableError.value = resource.getString(R.string.login_automatically_fail_message)
-                Timber.d(it, "Failed")
-            })
-    }
-
-    private fun fetchProfile() {
-        if (!isConnected()) return
-        compositeDisposable += authService.getProfile()
-            .withDefaultSchedulers()
-            .subscribe({
-                Timber.d("Fetched User Details")
-            }) {
-                Timber.e(it, "Error loading user details")
-            }
-    }
-
     override fun onCleared() {
         super.onCleared()
         compositeDisposable.clear()

app/src/main/java/org/fossasia/openevent/general/event/EventDetailsViewModel.kt

@@ -302,15 +302,15 @@ class EventDetailsViewModel(
         val range = StringBuilder()
         if (maxPrice == minPrice) {
             if (maxPrice == 0f)
-                range.append("Free")
+                range.append(resource.getString(R.string.free))
             else {
                 range.append(paymentCurrency)
                 range.append(" ")
                 range.append(minPrice)
             }
         } else {
             if (minPrice == 0f)
-                range.append("Free")
+                range.append(resource.getString(R.string.free))
             else {
                 range.append(paymentCurrency)
                 range.append(" ")

app/src/main/java/org/fossasia/openevent/general/order/OrderDetailsViewModel.kt

@@ -3,6 +3,7 @@ package org.fossasia.openevent.general.order
 import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.ViewModel
+import io.reactivex.Single
 import io.reactivex.disposables.CompositeDisposable
 import io.reactivex.rxkotlin.plusAssign
 import org.fossasia.openevent.general.utils.extensions.withDefaultSchedulers
@@ -54,31 +55,20 @@ class OrderDetailsViewModel(
     fun loadAttendeeDetails(orderId: Long) {
         if (orderId == -1L) return
 
-        compositeDisposable += orderService.getOrderById(orderId)
+        compositeDisposable += orderService
+            .getOrderById(orderId)
+            .flatMap { order ->
+                orderService.getAttendeesUnderOrder(order.identifier ?: "", order.attendees.map { it.id })
+            }
             .withDefaultSchedulers()
             .doOnSubscribe {
                 mutableProgress.value = true
-            }.subscribe({
-                loadAttendeeUnderOrder(it)
-            }, {
-                Timber.e(it, "Error fetching attendee details")
+            }.doFinally {
                 mutableProgress.value = false
-                message.value = resource.getString(R.string.error_fetching_attendee_details_message)
-            })
-    }
-
-    private fun loadAttendeeUnderOrder(order: Order) {
-        val orderIdentifier = order.identifier ?: return
-
-        compositeDisposable += orderService
-            .getAttendeesUnderOrder(orderIdentifier, order.attendees.map { it.id })
-            .withDefaultSchedulers()
-            .subscribe({
+            }.subscribe({
                 mutableAttendees.value = it
-                mutableProgress.value = false
             }, {
                 Timber.e(it, "Error fetching attendee details")
-                mutableProgress.value = false
                 message.value = resource.getString(R.string.error_fetching_attendee_details_message)
             })
     }