Skip to content

Conversation

@sibiraj-s
Copy link
Contributor

Drop pify in favour of util.promisify

Following up from forwardemail/email-templates#409.

@sibiraj-s
Copy link
Contributor Author

@niftylettuce. tracking email-templates package's dependencies and trying to reduce its install size.

Since node 8 is no longer in LTS. If it is okay drop that and by looking at the code we no longer will need babel. and also we can update someother dependencies as well. which can potentially reduce the size of the package. If you are okay with doing a major release I can make changes here as well as to the email-templates package?

Thoughts?

@niftylettuce
Copy link
Collaborator

yes you can drop Node 8 @sibiraj-s

@sibiraj-s
Copy link
Contributor Author

@niftylettuce I have made the changes. didn't update few things since there are other PR's around that. I will do a total dependency bump PR once other PR's related to dependencies are merged.

@niftylettuce niftylettuce merged commit b05e5b5 into forwardemail:master Nov 23, 2020
@niftylettuce
Copy link
Collaborator

v3.0.0 released https://github.com/forwardemail/preview-email/releases/tag/v3.0.0

@sibiraj-s
Copy link
Contributor Author

@niftylettuce with 3.0 there is a 3MB drop in install size.

Screenshot 2020-11-23 at 8 34 42 AM

@sibiraj-s sibiraj-s deleted the install-size branch November 23, 2020 03:06
@niftylettuce
Copy link
Collaborator

thank you @sibiraj-s - I'm also updating this in email-templates right now and bumping that to v8.0.0

@sibiraj-s
Copy link
Contributor Author

Great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants