build: move project setup to pyproject.toml #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a subtle difference with the Home-Page field in setuptools not being set via pypoject.toml. The version of setuptools has been bumped to 61+ to at least map the url "homepage" to Home-Page in PyPi. See relevant Issue on pypa: pypa/packaging-problems#606
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 35 35
Lines 4793 4793
=======================================
Hits 4205 4205
Misses 588 588 ☔ View full report in Codecov by Sentry. |
|
There is another subtle change in this PR, where the schema file is included in the tarball/wheel. I don't think that is a bad thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a subtle difference with the Home-Page field
in setuptools not being set via pypoject.toml.
The version of setuptools has been bumped to 61+ to at least
map the url "homepage" to Home-Page in PyPi.
See relevant Issue on pypa:
pypa/packaging-problems#606