-
-
Notifications
You must be signed in to change notification settings - Fork 48
feat: Import host association #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 86.63% 86.76% +0.13%
==========================================
Files 12 12
Lines 4475 4542 +67
==========================================
+ Hits 3877 3941 +64
- Misses 598 601 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
7fc7497
to
605ec78
Compare
for more information, see https://pre-commit.ci
There is some polishing of the code that is required but this is mostly done.
12aab70
to
202b496
Compare
gnikit
commented
Dec 4, 2022
gnikit
commented
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start for the work of import host association.
Currently, imports are treated the same way as
USE
objects, that is not very convenient sincewe cannot impose ALL, NONE and ONLY in a way that does not get polluted by the parent scopes
Fixes #5