Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error sourcing fcli_completion #580

Closed
rsenden opened this issue Aug 14, 2024 · 1 comment
Closed

Error sourcing fcli_completion #580

rsenden opened this issue Aug 14, 2024 · 1 comment
Labels
bug Something isn't working effort:medium Medium effort needed to implement/fix prio:high High priority; important new feature or bug fix

Comments

@rsenden
Copy link
Contributor

rsenden commented Aug 14, 2024

Current Behavior

Running source ./fcli_completion results in the following errors:

-bash: ./fcli_completion: line 6357: syntax error near unexpected token `<'
-bash: ./fcli_completion: line 6357: `    --<action-parameter>)'

Expected Behavior

The fcli_completion script should be sourced without any errors

Steps To Reproduce

  1. Download any recent fcli version (probably issue exists since fcli 2.4.0)
  2. Run source ./fcli_completion after extracting the download bundle

Environment

No response

Anything else?

This error is caused by the following option declaration in AbstractActionRunCommand; apparently the < and > in the option name cause errors in the completion script:

    @Option(names="--<action-parameter>", paramLabel="<value>", descriptionKey="fcli.action.run.action-parameter") 
    private List<String> dummyForSynopsis;

Easy fix would be to simply remove those characters from the option name, but that makes it less clear for users that this is not a literal option name. Any better approaches?

@rsenden rsenden added bug Something isn't working prio:high High priority; important new feature or bug fix effort:medium Medium effort needed to implement/fix labels Aug 14, 2024
@rsenden
Copy link
Contributor Author

rsenden commented Sep 10, 2024

Also see remkop/picocli#2336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort:medium Medium effort needed to implement/fix prio:high High priority; important new feature or bug fix
Projects
None yet
Development

No branches or pull requests

1 participant