Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate unwind safety of WaitQueue::wait #103

Closed
jethrogb opened this issue Feb 14, 2019 · 2 comments
Closed

Evaluate unwind safety of WaitQueue::wait #103

jethrogb opened this issue Feb 14, 2019 · 2 comments
Labels
bug security std/rustc Requires changes in Rust std/rustc

Comments

@jethrogb
Copy link
Member

If WaitQueue::wait unwinds, it leaves its entry in the UnsafeList. This is probably bad. Perhaps use rtassert/rtabort to avoid unwinding? Is there a way to make it unwind-safe?
@jethrogb jethrogb added bug security std/rustc Requires changes in Rust std/rustc labels Feb 14, 2019
@jethrogb
Copy link
Member Author

rust-lang/rust@master...jethrogb:jb/waitqueue-wait-unwind

@jethrogb jethrogb mentioned this issue Apr 1, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Apr 1, 2019
@Centril
Rollup merge of rust-lang#59613 - jethrogb:jb/waitqueue-wait-unwind, …
4747bbe 
…r=alexcrichton

SGX target: convert a bunch of panics to aborts

Fixes fortanix/rust-sgx#86, fortanix/rust-sgx#103 and in general protect preemptively against Iago attacks by aborting instead of unwinding in potentially unexpected situations.
Centril added a commit to Centril/rust that referenced this issue Apr 2, 2019
@Centril
Rollup merge of rust-lang#59613 - jethrogb:jb/waitqueue-wait-unwind, …
d0d3466 
…r=alexcrichton

SGX target: convert a bunch of panics to aborts

Fixes fortanix/rust-sgx#86, fortanix/rust-sgx#103 and in general protect preemptively against Iago attacks by aborting instead of unwinding in potentially unexpected situations.
@jethrogb
Copy link
Member Author

jethrogb commented Oct 8, 2019

Fixed by rust-lang/rust#59613

@jethrogb jethrogb closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug security std/rustc Requires changes in Rust std/rustc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jethrogb