Skip to content

Commit 541f3d8

Browse files
committed
Merge tag 'clk-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
Pull clk fixes from Stephen Boyd: "A handful of Qualcomm clk driver fixes: - Correct flags for X Elite USB MP GDSC and pcie pipediv2 clocks - Fix alpha PLL post_div mask for the cases where width is not specified - Avoid hangs in the SM8350 video driver (venus) by setting HW_CTRL trigger feature on the video clocks" * tag 'clk-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux: clk: qcom: gcc-x1e80100: Fix USB MP SS1 PHY GDSC pwrsts flags clk: qcom: gcc-x1e80100: Fix halt_check for pipediv2 clocks clk: qcom: clk-alpha-pll: Fix pll post div mask when width is not set clk: qcom: videocc-sm8350: use HW_CTRL_TRIGGER for vcodec GDSCs
2 parents d7e67a9 + 714398d commit 541f3d8

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

drivers/clk/qcom/clk-alpha-pll.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040

4141
#define PLL_USER_CTL(p) ((p)->offset + (p)->regs[PLL_OFF_USER_CTL])
4242
# define PLL_POST_DIV_SHIFT 8
43-
# define PLL_POST_DIV_MASK(p) GENMASK((p)->width - 1, 0)
43+
# define PLL_POST_DIV_MASK(p) GENMASK((p)->width ? (p)->width - 1 : 3, 0)
4444
# define PLL_ALPHA_MSB BIT(15)
4545
# define PLL_ALPHA_EN BIT(24)
4646
# define PLL_ALPHA_MODE BIT(25)

drivers/clk/qcom/gcc-x1e80100.c

+6-6
Original file line numberDiff line numberDiff line change
@@ -3123,7 +3123,7 @@ static struct clk_branch gcc_pcie_3_pipe_clk = {
31233123

31243124
static struct clk_branch gcc_pcie_3_pipediv2_clk = {
31253125
.halt_reg = 0x58060,
3126-
.halt_check = BRANCH_HALT_VOTED,
3126+
.halt_check = BRANCH_HALT_SKIP,
31273127
.clkr = {
31283128
.enable_reg = 0x52020,
31293129
.enable_mask = BIT(5),
@@ -3248,7 +3248,7 @@ static struct clk_branch gcc_pcie_4_pipe_clk = {
32483248

32493249
static struct clk_branch gcc_pcie_4_pipediv2_clk = {
32503250
.halt_reg = 0x6b054,
3251-
.halt_check = BRANCH_HALT_VOTED,
3251+
.halt_check = BRANCH_HALT_SKIP,
32523252
.clkr = {
32533253
.enable_reg = 0x52010,
32543254
.enable_mask = BIT(27),
@@ -3373,7 +3373,7 @@ static struct clk_branch gcc_pcie_5_pipe_clk = {
33733373

33743374
static struct clk_branch gcc_pcie_5_pipediv2_clk = {
33753375
.halt_reg = 0x2f054,
3376-
.halt_check = BRANCH_HALT_VOTED,
3376+
.halt_check = BRANCH_HALT_SKIP,
33773377
.clkr = {
33783378
.enable_reg = 0x52018,
33793379
.enable_mask = BIT(19),
@@ -3511,7 +3511,7 @@ static struct clk_branch gcc_pcie_6a_pipe_clk = {
35113511

35123512
static struct clk_branch gcc_pcie_6a_pipediv2_clk = {
35133513
.halt_reg = 0x31060,
3514-
.halt_check = BRANCH_HALT_VOTED,
3514+
.halt_check = BRANCH_HALT_SKIP,
35153515
.clkr = {
35163516
.enable_reg = 0x52018,
35173517
.enable_mask = BIT(28),
@@ -3649,7 +3649,7 @@ static struct clk_branch gcc_pcie_6b_pipe_clk = {
36493649

36503650
static struct clk_branch gcc_pcie_6b_pipediv2_clk = {
36513651
.halt_reg = 0x8d060,
3652-
.halt_check = BRANCH_HALT_VOTED,
3652+
.halt_check = BRANCH_HALT_SKIP,
36533653
.clkr = {
36543654
.enable_reg = 0x52010,
36553655
.enable_mask = BIT(28),
@@ -6155,7 +6155,7 @@ static struct gdsc gcc_usb3_mp_ss1_phy_gdsc = {
61556155
.pd = {
61566156
.name = "gcc_usb3_mp_ss1_phy_gdsc",
61576157
},
6158-
.pwrsts = PWRSTS_OFF_ON,
6158+
.pwrsts = PWRSTS_RET_ON,
61596159
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
61606160
};
61616161

drivers/clk/qcom/videocc-sm8350.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ static struct gdsc mvs0_gdsc = {
452452
.pd = {
453453
.name = "mvs0_gdsc",
454454
},
455-
.flags = HW_CTRL | RETAIN_FF_ENABLE,
455+
.flags = HW_CTRL_TRIGGER | RETAIN_FF_ENABLE,
456456
.pwrsts = PWRSTS_OFF_ON,
457457
};
458458

@@ -461,7 +461,7 @@ static struct gdsc mvs1_gdsc = {
461461
.pd = {
462462
.name = "mvs1_gdsc",
463463
},
464-
.flags = HW_CTRL | RETAIN_FF_ENABLE,
464+
.flags = HW_CTRL_TRIGGER | RETAIN_FF_ENABLE,
465465
.pwrsts = PWRSTS_OFF_ON,
466466
};
467467

0 commit comments

Comments
 (0)