Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size of sun in 2x1 and 3x1 lightmap widget #624

Closed
onlycparra opened this issue Sep 21, 2022 · 2 comments · Fixed by #636
Closed

Size of sun in 2x1 and 3x1 lightmap widget #624

onlycparra opened this issue Sep 21, 2022 · 2 comments · Fixed by #636
Labels

Comments

@onlycparra
Copy link

The size of the sun is too small, which makes it difficult to see (the low color contrast doesn't help). I attach a screenshot. I think the upper two instances have a too tiny sun.

Screenshot_20220921-110155_One UI Home

Thanks.

@forrestguice
Copy link
Owner

Yeah, that is difficult to see.
If I remember, the circle is scaled to a 'half hour wide', so the reduced width is directly to blame. I guess the fix is to constrain it to some minimum size, or maybe a constraint on height (maybe no less than 1/4 the height).

By the way, those colors can be changed by applying a theme. From the widget configuration tap 'Theme' (next to the selector). I think contrast is fine at the larger sizes (but I'm open to revising default colors too).

@onlycparra
Copy link
Author

Thanks for the quick answer.
The function of the widget (to me) is to have a quick perception of the
remaining day. So a big (even huge) sun is great.

Let ph, pw be the widget's  height and width in pixels (or the
corresponding units). And diam the sun's diameter:

diam = ...
ms = min(ph, pw)
if not (diam >= ms/4 && diam <= 3*ms/4):
    diam = ms/2

I think that is a complete constraining that should deal with exotic
homescreens and corner cases.

Claudio

PS: I like the coloring.
PS2: I am thinking now that a vertical lightmap would be cool...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants