Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alarm dialog fails to consume touch events #529

Closed
forrestguice opened this issue Jan 1, 2022 · 0 comments · Fixed by #534
Closed

alarm dialog fails to consume touch events #529

forrestguice opened this issue Jan 1, 2022 · 0 comments · Fixed by #534

Comments

@forrestguice
Copy link
Owner

forrestguice commented Jan 1, 2022

The alarm dialog fails to completely consume touch events, but instead allows some events to pass to the view behind it.

To reproduce:

  1. Open the SuntimesAlarms activity.
  2. Create several alarms if the list is empty (enough to cause the list to scroll).
  3. Click the Add (+) button (opens the alarm dialog)
  4. Click the Time tab (displays time picker).
  5. Swipe up/down in the white space beside the picker.
    Observe: the list behind the dialog scrolls up/down; the touch events that are not caught by the picker are instead caught by the list.
  6. Tap the white space beside the picker.
    Observe: the list item behind the dialog is now selected; if it was already selected then the EditActivity is launched.
forrestguice added a commit that referenced this issue Jan 12, 2022
bottom sheet layout catches click events (#529)
@forrestguice forrestguice added this to the v0.13.18 milestone Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant