Skip to content

FIO-9918 Removed potential trailing slashes in baseURL #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antonSoftensity
Copy link

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9918

Description

Removed trailing slashes from setBaseUrl, which caused incorrect requests in some cases. Switching requests to URL object was attempted, but it created a lot more issues.

Breaking Changes / Backwards Compatibility

Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility

Dependencies

Use this section to list any dependent changes/PRs in other Form.io modules

How has this PR been tested?

Use this section to describe how you tested your changes; if you haven't included automated tests, justify your reasoning

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do something besides a brittle regex test here? I'd probably reach for new URL in this case to create a deterministic URL every time.

Also, please don't forget tests!

@johnformio
Copy link
Contributor

@antonSoftensity I know you said using the URL object created more object, but I think we should try again. I would start with changing the type of any url parameter to be URL and make sure we are joining the parts to the URL or creating new ones. For example, this creates a valid URL:

const URL = new URL('/abc', 'https://example.com/')

it's just a larger refactor this way, but way safer in the long run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants