feat: prevent potential deadlocks #768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Add Flake * ci: Rework tests - Add ginkgo to the list of dependencies in flake.nix - Remove unnecessary CACHE directives in Earthfile - Simplify 'compile' section in Earthfile - Simplify 'tests' section in Earthfile - Simplify 'lint' section in Earthfile - Simplify 'pre-commit' section in Earthfile - Simplify 'pre-commit-nix' section in Earthfile - Simplify 'tidy' section in Earthfile - Simplify 'export-docs-events' section in Earthfile feat/nix * ci: Rework config * ci: Rework config Reworked config to use 'nix develop' with 'earthly' command. Added 'pre-commit-nix' hook. Removed unnecessary flags and secrets. (feat/nix) * ci: Rework config Reworked config to use 'nix develop' with 'earthly' command. Added 'pre-commit-nix' hook. Removed unnecessary flags and secrets. (feat/nix) * ci: Rework config Reworked config to use 'nix develop' with 'earthly' command. Added 'pre-commit-nix' hook. Removed unnecessary flags and secrets. (feat/nix) * ci: Rework config Reworked config to use 'nix develop' with 'earthly' command. Added 'pre-commit-nix' hook. Removed unnecessary flags and secrets. (feat/nix) * ci: Rework config Reworked config to use 'nix develop' with 'earthly' command. Added 'pre-commit-nix' hook. Removed unnecessary flags and secrets. (feat/nix) * ci: Rework config Reworked config to use 'nix develop' with 'earthly' command. Added 'pre-commit-nix' hook. Removed unnecessary flags and secrets. (feat/nix) * ci: Rework config Reworked config to use 'nix develop' with 'earthly' command. Added 'pre-commit-nix' hook. Removed unnecessary flags and secrets. (feat/nix) * ci: Rework config Reworked config to use 'nix develop' with 'earthly' command. Added 'pre-commit-nix' hook. Removed unnecessary flags and secrets. (feat/nix) * feat(ledger): optimize release script in Earthfile (issue #123) * Add .envrc and update .gitignore to track it Added a new .envrc file with configuration for direnv and updated .gitignore to include .envrc while still ignoring .env files. This ensures proper local environment setup using direnv without accidentally committing sensitive .env files. * Add missing `isgomock` struct to mock test files This change ensures all mock test files include the `isgomock` struct, standardizing the structure of generated mocks. This addition aligns with gomock's conventions and facilitates internal consistency across mock definitions. * chore: migrate from Earthly to Just for build and workflow automation This change replaces Earthly with Just by removing Earthfiles and introducing a Justfile. Benefits include streamlining the dependency management, simplifying workflow automation, and improving build process readability. Build and CI workflows (e.g., pre-commit, tests, linting) have been adapted to utilize Just commands, ensuring consistency across development processes. * build(workflow): update CI to simplify release commands Replaced complex earthly-based release command with a `just` target in the CI workflow for better maintainability. Added new `release` commands to the Justfile for local, CI, and standard releases. This streamlines the release process and enhances clarity. * refactor: simplify and streamline build and lint processes - Removed unused 'group' annotation in Justfile to enhance clarity. - Consolidated COPY commands in Earthfile for better maintainability. - Updated 'compile' stage in Earthfile to use 'sources' for consistency. These changes reduce redundancy, improve readability, and ensure less complexity in maintenance. * fix(justfile): reorder pre-commit tasks for consistent execution flow Reordered tasks in the pre-commit command to ensure `generate` and `earthly` execute before `tidy`, `lint`, and `export-docs-events`. This improves maintainability and ensures prerequisites are met. * chore(ci): update release workflow to use nix and just for releases Replaced `earthly` with `nix` and `just` in the release workflow. This improves build consistency and leverages flakes for reproducibility. * test(mock): add `isgomock` struct to mock types Added `isgomock` struct to mock types in tests to enhance clarity and identification of GoMock-generated code structure.
* chore: upgrade dependencies * fix: pre commit
* fix: coverage * fix(ci): add EARTHLY_SECRETS for improved build compatibility Added EARTHLY_SECRETS environment variable to streamline integration with Earthly by consolidating critical secrets, improving CI builds. * fix(ci): remove redundant EARTHLY_SECRETS and use explicit secrets Removed unused EARTHLY_SECRETS from GitHub Actions for simplification. Updated Earthly command in Justfile to explicitly pass required secrets, enhancing security and maintainability in CI workflows. --------- Co-authored-by: Maxence Maireaux <maxence@maireaux.fr>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.2.0 to 5.1.2. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.2.0...v5.1.2) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: integrate OpenAPI generation into `Justfile` and simplify `Earthfile` - Added `openapi` task to `Justfile` for merging specs and generating docs. - Removed OpenAPI-related tasks from `Earthfile` in favor of `Justfile`. - Streamlined pre-commit process by centralizing OpenAPI steps in `Justfile`. This simplifies the OpenAPI generation workflow and reduces duplication, making the development process more efficient and maintainable. * feat: integrate speakeasy CLI and improve build workflows - Add speakeasy CLI as an installable package in the Nix Flake. - Support multiple platforms with pre-defined hashes and binaries. - Enhance Nix devShells by including speakeasy for supported systems. - Simplify Justfile tasks by removing redundant Earthly build steps. - Update speakeasy generate command in Justfile for better usability. - Refactor workflows to eliminate unnecessary steps in Earthfile. These changes streamline SDK generation, improve multi-platform support, and reduce reliance on Earthly for local builds.
Added a new task `openapi` to manage OpenAPI specification by copying `openapi.yaml` and saving it as an artifact. This enhances automation and ensures consistent handling of OpenAPI files.
* feat: remove earthly usage for benchmarks * chore: remove commited js files * feat: use ephemeral postgres for benchmarks (cause regression error) * feat(benchmarks): use compare recipe instead of run on prs * feat: properly clean postgres servers * fix: create output directory * feat: increase benchmarks timeout * feat: benchmarks and add inputs on workflow dispatch * feat: use nix to setup just * fix: nix usage
was comparing self with self
* fix: migration using azure postgres with no superuser provileges * fix: next migration
* feat: added numscript feature flag * fix: allow passing the flag * refactor: use builtin function for slice string * refactor: changed flags list representation
…with more than 7 digits (#698)
* chore: bump numscript version * fix: run go mod tidy on generator
…re not terminated (#723)
* refactor: simplify cli args handling * feat: remove bad comment
Improve performance of rollback detection by processing buckets concurrently using a worker pool. Added configurable parallel workers with a default of 100, and implemented error handling for multiple potential failures during the process.
#766) * feat: upgrade skeapeasy and use streaming file system for logs imports * feat: use speakeasy workflow to regenerate the sdk * fix: add staticcheck for speakeasy
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis change introduces a new deadlock prevention mechanism in the Changes
Sequence Diagram(s)sequenceDiagram
participant C as Client
participant G as GetBalances
participant S as Sorting (slices package)
participant D as Database
C->>G: Call GetBalances()
G->>S: Sort accountsVolumes by Account, Asset
S-->>G: Return sorted slice
G->>D: Acquire locks in consistent order
D-->>G: Process balance retrieval
G->>C: Return balances
Possibly related PRs
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v2.2 #768 +/- ##
===============================================
Coverage ? 81.80%
===============================================
Files ? 136
Lines ? 7306
Branches ? 0
===============================================
Hits ? 5977
Misses ? 1022
Partials ? 307 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gfyrag
force-pushed
the
hotfix/v2.2/prevent-some-deadlocks
branch
from
963a0b3 to
3ae6856
Compare
auto-merge was automatically disabled
March 14, 2025 08:01
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.