refactor: split index migrations into isolated concurrent operations

Split the single migration 41 into 5 separate migrations:
- Migration 41: Create idx_moves_pit_insertion index
- Migration 42: Create idx_moves_pit_effective index
- Migration 43: Create idx_accounts_metadata_pit index
- Migration 44: Create idx_transactions_metadata_pit index
- Migration 45: Drop all old indexes

This ensures each concurrent index creation is isolated in its own
migration, and all index drops are consolidated into a final migration.
Also removed the optional idx_moves_account_balance index on Moves table.

Author: flemzord

internal/storage/bucket/migrations/41-optimize-query-indexes/up.sql

@@ -1,66 +1,11 @@
 set search_path = '{{.Schema}}';
 
 -- ========================================
--- MOVES TABLE INDEXES OPTIMIZATION
+-- MOVES TABLE INDEXES OPTIMIZATION (1/4)
 -- ========================================
 
--- Step 1: Create new optimized indexes FIRST to avoid performance degradation
 -- Critical: Index for Point-in-Time queries with insertion_date
 -- Covers queries in resource_aggregated_balances.go and resource_accounts.go
 -- Replaces: moves_post_commit_volumes
 create index {{ if not .Transactional }}concurrently{{end}} idx_moves_pit_insertion
     on "{{.Schema}}".moves (account_address, asset, insertion_date desc, seq desc);
-
--- Critical: Index for Point-in-Time queries with effective_date
--- Covers queries in resource_aggregated_balances.go and resource_accounts.go
--- Replaces: moves_effective_post_commit_volumes
-create index {{ if not .Transactional }}concurrently{{end}} idx_moves_pit_effective
-    on "{{.Schema}}".moves (account_address, asset, effective_date desc, seq desc);
-
--- Optimal: Index for balance lookups by account with effective date
--- Covers balance filtering queries in resource_accounts.go
-create index {{ if not .Transactional }}concurrently{{end}} idx_moves_account_balance
-    on "{{.Schema}}".moves (account_address, effective_date desc, seq desc)
-    include (asset, post_commit_effective_volumes);
-
--- Step 2: Drop old suboptimal indexes AFTER new ones are ready
-drop index if exists moves_post_commit_volumes;
-drop index if exists moves_effective_post_commit_volumes;
-
--- ========================================
--- ACCOUNTS_METADATA TABLE OPTIMIZATION
--- ========================================
-
--- Step 1: Create new optimized index FIRST
--- Critical: Index for historical metadata queries
--- Covers queries in resource_accounts.go for Point-in-Time metadata
--- Replaces: accounts_metadata_revisions
-create index {{ if not .Transactional }}concurrently{{end}} idx_accounts_metadata_pit
-    on "{{.Schema}}".accounts_metadata (accounts_address, revision desc)
-    include (metadata, date);
-
--- Step 2: Drop old suboptimal index AFTER new one is ready
-drop index if exists accounts_metadata_revisions;
-
--- ========================================
--- TRANSACTIONS_METADATA TABLE OPTIMIZATION
--- ========================================
-
--- Step 1: Create new optimized index FIRST
--- Critical: Index for historical transaction metadata queries
--- Covers queries in resource_transactions.go for Point-in-Time metadata
--- Replaces: transactions_metadata_revisions
-create index {{ if not .Transactional }}concurrently{{end}} idx_transactions_metadata_pit
-    on "{{.Schema}}".transactions_metadata (transactions_id, revision desc)
-    include (metadata, date);
-
--- Step 2: Drop old suboptimal index AFTER new one is ready
-drop index if exists transactions_metadata_revisions;
-
--- ========================================
--- ACCOUNTS_VOLUMES TABLE CLEANUP
--- ========================================
-
--- Drop redundant index - PRIMARY KEY already covers this pattern
--- Safe to drop immediately as PRIMARY KEY provides same functionality
-drop index if exists accounts_volumes_idx;

internal/storage/bucket/migrations/42-optimize-query-indexes-pit-effective/up.sql

@@ -0,0 +1,11 @@
+set search_path = '{{.Schema}}';
+
+-- ========================================
+-- MOVES TABLE INDEXES OPTIMIZATION (2/4)
+-- ========================================
+
+-- Critical: Index for Point-in-Time queries with effective_date
+-- Covers queries in resource_aggregated_balances.go and resource_accounts.go
+-- Replaces: moves_effective_post_commit_volumes
+create index {{ if not .Transactional }}concurrently{{end}} idx_moves_pit_effective
+    on "{{.Schema}}".moves (account_address, asset, effective_date desc, seq desc);

internal/storage/bucket/migrations/43-optimize-accounts-metadata-index/up.sql

@@ -0,0 +1,12 @@
+set search_path = '{{.Schema}}';
+
+-- ========================================
+-- ACCOUNTS_METADATA TABLE OPTIMIZATION
+-- ========================================
+
+-- Critical: Index for historical metadata queries
+-- Covers queries in resource_accounts.go for Point-in-Time metadata
+-- Replaces: accounts_metadata_revisions
+create index {{ if not .Transactional }}concurrently{{end}} idx_accounts_metadata_pit
+    on "{{.Schema}}".accounts_metadata (accounts_address, revision desc)
+    include (metadata, date);

internal/storage/bucket/migrations/44-optimize-transactions-metadata-index/up.sql

@@ -0,0 +1,12 @@
+set search_path = '{{.Schema}}';
+
+-- ========================================
+-- TRANSACTIONS_METADATA TABLE OPTIMIZATION
+-- ========================================
+
+-- Critical: Index for historical transaction metadata queries
+-- Covers queries in resource_transactions.go for Point-in-Time metadata
+-- Replaces: transactions_metadata_revisions
+create index {{ if not .Transactional }}concurrently{{end}} idx_transactions_metadata_pit
+    on "{{.Schema}}".transactions_metadata (transactions_id, revision desc)
+    include (metadata, date);

internal/storage/bucket/migrations/45-drop-old-indexes/up.sql

@@ -0,0 +1,18 @@
+set search_path = '{{.Schema}}';
+
+-- ========================================
+-- DROP OLD INDEXES
+-- ========================================
+
+-- Drop old moves table indexes (replaced by migrations 41-42)
+drop index if exists moves_post_commit_volumes;
+drop index if exists moves_effective_post_commit_volumes;
+
+-- Drop old accounts_metadata index (replaced by migration 43)
+drop index if exists accounts_metadata_revisions;
+
+-- Drop old transactions_metadata index (replaced by migration 44)
+drop index if exists transactions_metadata_revisions;
+
+-- Drop redundant accounts_volumes index - PRIMARY KEY already covers this pattern
+drop index if exists accounts_volumes_idx;