test: update metadata deletion tests to use Expect for improved readability and error handling

Author: flemzord

internal/api/common/errors.go

@@ -30,14 +30,28 @@ const (
 	ErrScriptMetadataOverride  = "METADATA_OVERRIDE"
 )
 
-func HandleCommonErrors(w http.ResponseWriter, r *http.Request, err error) {
+// HandleCommonWriteErrors gère spécifiquement les erreurs liées aux opérations d'écriture
+// telles que les erreurs d'idempotence
+func HandleCommonWriteErrors(w http.ResponseWriter, r *http.Request, err error) {
 	switch {
-	case errors.Is(err, postgres.ErrTooManyClient{}):
-		api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
 	case errors.Is(err, ledgercontroller.ErrIdempotencyKeyConflict{}):
 		api.WriteErrorResponse(w, http.StatusConflict, ErrConflict, err)
 	case errors.Is(err, ledgercontroller.ErrInvalidIdempotencyInput{}):
 		api.BadRequest(w, ErrValidation, err)
+	case errors.Is(err, ledgercontroller.ErrTransactionReferenceConflict{}):
+		api.WriteErrorResponse(w, http.StatusConflict, ErrConflict, err)
+	case errors.Is(err, ledgercontroller.ErrNotFound):
+		api.NotFound(w, err)
+	default:
+		HandleCommonErrors(w, r, err)
+	}
+}
+
+// HandleCommonErrors gère les erreurs communes plus générales
+func HandleCommonErrors(w http.ResponseWriter, r *http.Request, err error) {
+	switch {
+	case errors.Is(err, postgres.ErrTooManyClient{}):
+		api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
 	default:
 		InternalServerError(w, r, err)
 	}

internal/api/v1/controllers_accounts_add_metadata.go

@@ -40,7 +40,7 @@ func addAccountMetadata(w http.ResponseWriter, r *http.Request) {
 		Metadata: m,
 	}))
 	if err != nil {
-		common.HandleCommonErrors(w, r, err)
+		common.HandleCommonWriteErrors(w, r, err)
 		return
 	}
 

internal/api/v1/controllers_accounts_delete_metadata.go

@@ -26,7 +26,7 @@ func deleteAccountMetadata(w http.ResponseWriter, r *http.Request) {
 				Key:     chi.URLParam(r, "key"),
 			}),
 		); err != nil {
-		common.HandleCommonErrors(w, r, err)
+		common.HandleCommonWriteErrors(w, r, err)
 		return
 	}
 

internal/api/v1/controllers_transactions_add_metadata.go

@@ -37,7 +37,7 @@ func addTransactionMetadata(w http.ResponseWriter, r *http.Request) {
 		if errors.Is(err, ledgercontroller.ErrNotFound) {
 			api.NotFound(w, err)
 		} else {
-			common.HandleCommonErrors(w, r, err)
+			common.HandleCommonWriteErrors(w, r, err)
 		}
 		return
 	}

internal/api/v1/controllers_transactions_create.go

@@ -98,7 +98,7 @@ func createTransaction(w http.ResponseWriter, r *http.Request) {
 			case errors.Is(err, ledgercontroller.ErrTransactionReferenceConflict{}):
 				api.WriteErrorResponse(w, http.StatusConflict, common.ErrConflict, err)
 			default:
-				common.HandleCommonErrors(w, r, err)
+				common.HandleCommonWriteErrors(w, r, err)
 			}
 			return
 		}
@@ -132,7 +132,7 @@ func createTransaction(w http.ResponseWriter, r *http.Request) {
 		case errors.Is(err, ledgercontroller.ErrTransactionReferenceConflict{}):
 			api.WriteErrorResponse(w, http.StatusConflict, common.ErrConflict, err)
 		default:
-			common.HandleCommonErrors(w, r, err)
+			common.HandleCommonWriteErrors(w, r, err)
 		}
 		return
 	}

internal/api/v1/controllers_transactions_delete_metadata.go

@@ -28,11 +28,7 @@ func deleteTransactionMetadata(w http.ResponseWriter, r *http.Request) {
 		TransactionID: int(transactionID),
 		Key:           metadataKey,
 	})); err != nil {
-		if errors.Is(err, ledgercontroller.ErrNotFound) {
-			api.NotFound(w, err)
-		} else {
-			common.HandleCommonErrors(w, r, err)
-		}
+		common.HandleCommonWriteErrors(w, r, err)
 		return
 	}
 

internal/api/v2/controllers_accounts_add_metadata.go

@@ -41,7 +41,7 @@ func addAccountMetadata(w http.ResponseWriter, r *http.Request) {
 		Metadata: m,
 	}))
 	if err != nil {
-		common.HandleCommonErrors(w, r, err)
+		common.HandleCommonWriteErrors(w, r, err)
 		return
 	}
 

internal/api/v2/controllers_accounts_delete_metadata.go

@@ -27,7 +27,7 @@ func deleteAccountMetadata(w http.ResponseWriter, r *http.Request) {
 				Key:     chi.URLParam(r, "key"),
 			}),
 		); err != nil {
-		common.HandleCommonErrors(w, r, err)
+		common.HandleCommonWriteErrors(w, r, err)
 		return
 	}
 

internal/api/v2/controllers_transactions_add_metadata.go

@@ -34,11 +34,7 @@ func addTransactionMetadata(w http.ResponseWriter, r *http.Request) {
 		TransactionID: int(txID),
 		Metadata:      m,
 	})); err != nil {
-		if errors.Is(err, ledgercontroller.ErrNotFound) {
-			api.NotFound(w, err)
-		} else {
-			common.HandleCommonErrors(w, r, err)
-		}
+		common.HandleCommonWriteErrors(w, r, err)
 		return
 	}
 

internal/api/v2/controllers_transactions_create.go

@@ -50,14 +50,12 @@ func createTransaction(w http.ResponseWriter, r *http.Request) {
 			api.BadRequest(w, common.ErrMetadataOverride, err)
 		case errors.Is(err, ledgercontroller.ErrNoPostings):
 			api.BadRequest(w, common.ErrNoPostings, err)
-		case errors.Is(err, ledgercontroller.ErrTransactionReferenceConflict{}):
-			api.WriteErrorResponse(w, http.StatusConflict, common.ErrConflict, err)
 		case errors.Is(err, ledgercontroller.ErrParsing{}):
 			api.BadRequest(w, common.ErrInterpreterParse, err)
 		case errors.Is(err, ledgercontroller.ErrRuntime{}):
 			api.BadRequest(w, common.ErrInterpreterRuntime, err)
 		default:
-			common.HandleCommonErrors(w, r, err)
+			common.HandleCommonWriteErrors(w, r, err)
 		}
 		return
 	}