fix(ledger) tx reversion handles empty middle accounts

crosleyzack · crosleyzack · commit 667e480d62cb · 2025-02-25T14:17:52.000-05:00
diff --git a/internal/controller/ledger/controller_default.go b/internal/controller/ledger/controller_default.go
@@ -406,6 +406,13 @@ func (ctrl *DefaultController) revertTransaction(ctx context.Context, store Stor
 				balances[posting.Source][posting.Asset],
 				big.NewInt(0).Neg(posting.Amount),
 			)
+			if _, ok := balances[posting.Destination]; ok {
+				// if destination is also a source in some posting, since balances should only contain posting sources
+				balances[posting.Destination][posting.Asset] = balances[posting.Destination][posting.Asset].Add(
+					balances[posting.Destination][posting.Asset],
+					posting.Amount,
+				)
+			}
 		}
 
 		for account, forAccount := range balances {

Original file line number	Diff line number	Diff line change
`@@ -406,6 +406,13 @@ func (ctrl *DefaultController) revertTransaction(ctx context.Context, store Stor`
`406`	`406`	`balances[posting.Source][posting.Asset],`
`407`	`407`	`big.NewInt(0).Neg(posting.Amount),`
`408`	`408`	`)`
	`409`	`+ if _, ok := balances[posting.Destination]; ok {`
	`410`	`+ // if destination is also a source in some posting, since balances should only contain posting sources`
	`411`	`+ balances[posting.Destination][posting.Asset] = balances[posting.Destination][posting.Asset].Add(`
	`412`	`+ balances[posting.Destination][posting.Asset],`
	`413`	`+ posting.Amount,`
	`414`	`+ )`
	`415`	`+ }`
`409`	`416`	`}`
`410`	`417`
`411`	`418`	`for account, forAccount := range balances {`