fix: inconsistent accounts list

Author: gfyrag

internal/storage/ledger/accounts_test.go

@@ -53,6 +53,12 @@ func TestAccountsList(t *testing.T) {
 		},
 	}))
 
+	err = store.CommitTransaction(ctx, pointer.For(ledger.NewTransaction().
+		WithPostings(ledger.NewPosting("world", "account:1", "USD", big.NewInt(100))).
+		WithTimestamp(now).
+		WithInsertedAt(now)), nil)
+	require.NoError(t, err)
+
 	err = store.CommitTransaction(ctx, pointer.For(ledger.NewTransaction().
 		WithPostings(ledger.NewPosting("world", "account:1", "USD", big.NewInt(100))).
 		WithTimestamp(now.Add(4*time.Minute)).
@@ -112,7 +118,7 @@ func TestAccountsList(t *testing.T) {
 		require.NoError(t, err)
 		require.Len(t, accounts.Data, 1)
 		require.Equal(t, ledger.VolumesByAssets{
-			"USD": ledger.NewVolumesInt64(200, 50),
+			"USD": ledger.NewVolumesInt64(300, 50),
 		}, accounts.Data[0].Volumes)
 	})
 
@@ -129,7 +135,7 @@ func TestAccountsList(t *testing.T) {
 		require.NoError(t, err)
 		require.Len(t, accounts.Data, 1)
 		require.Equal(t, ledger.VolumesByAssets{
-			"USD": ledger.NewVolumesInt64(100, 0),
+			"USD": ledger.NewVolumesInt64(200, 0),
 		}, accounts.Data[0].Volumes)
 	})
 
@@ -145,7 +151,7 @@ func TestAccountsList(t *testing.T) {
 		require.NoError(t, err)
 		require.Len(t, accounts.Data, 1)
 		require.Equal(t, ledger.VolumesByAssets{
-			"USD": ledger.NewVolumesInt64(200, 50),
+			"USD": ledger.NewVolumesInt64(300, 50),
 		}, accounts.Data[0].EffectiveVolumes)
 	})
 
@@ -161,7 +167,7 @@ func TestAccountsList(t *testing.T) {
 		require.NoError(t, err)
 		require.Len(t, accounts.Data, 1)
 		require.Equal(t, ledger.VolumesByAssets{
-			"USD": ledger.NewVolumesInt64(100, 0),
+			"USD": ledger.NewVolumesInt64(200, 0),
 		}, accounts.Data[0].EffectiveVolumes)
 	})
 

internal/storage/ledger/resource_accounts.go

@@ -162,7 +162,7 @@ func (h accountsResourceHandler) expand(store *Store, opts ledgercontroller.Reso
 				Where("insertion_date <= ?", opts.PIT)
 		} else {
 			selectRowsQuery = selectRowsQuery.
-				ColumnExpr("first_value(post_commit_volumes) over (partition by (accounts_address, asset) order by effective_date desc) as volumes").
+				ColumnExpr("first_value(post_commit_volumes) over (partition by (accounts_address, asset) order by effective_date desc, seq desc) as volumes").
 				Where("effective_date <= ?", opts.PIT)
 		}
 	} else {