feat: add update of exporters config.

Also, fix a blocking stop of the app when the exporter config is erroned.

Author: gfyrag

docs/api/README.md

@@ -2377,6 +2377,62 @@ Status Code **200**
 This operation does not require authentication
 </aside>
 
+## Update exporter
+
+<a id="opIdv2UpdateExporter"></a>
+
+> Code samples
+
+```http
+PUT http://localhost:8080/v2/_/exporters/{exporterID} HTTP/1.1
+Host: localhost:8080
+Content-Type: application/json
+Accept: application/json
+
+```
+
+`PUT /v2/_/exporters/{exporterID}`
+
+> Body parameter
+
+```json
+{
+  "driver": "string",
+  "config": {}
+}
+```
+
+<h3 id="update-exporter-parameters">Parameters</h3>
+
+|Name|In|Type|Required|Description|
+|---|---|---|---|---|
+|body|body|[V2ExporterConfiguration](#schemav2exporterconfiguration)|true|none|
+|exporterID|path|string|true|The exporter id|
+
+> Example responses
+
+> default Response
+
+```json
+{
+  "errorCode": "VALIDATION",
+  "errorMessage": "[VALIDATION] invalid 'cursor' query param",
+  "details": "https://play.numscript.org/?payload=eyJlcnJvciI6ImFjY291bnQgaGFkIGluc3VmZmljaWVudCBmdW5kcyJ9"
+}
+```
+
+<h3 id="update-exporter-responses">Responses</h3>
+
+|Status|Meaning|Description|Schema|
+|---|---|---|---|
+|204|[No Content](https://tools.ietf.org/html/rfc7231#section-6.3.5)|Exporter updated|None|
+|default|Default|Error|[V2ErrorResponse](#schemav2errorresponse)|
+
+<aside class="warning">
+To perform this operation, you must be authenticated by means of one of the following methods:
+Authorization ( Scopes: ledger:write )
+</aside>
+
 ## Delete exporter
 
 <a id="opIdv2DeleteExporter"></a>
@@ -5483,6 +5539,25 @@ and
 
 *None*
 
+<h2 id="tocS_V2UpdateExporterRequest">V2UpdateExporterRequest</h2>
+<!-- backwards compatibility -->
+<a id="schemav2updateexporterrequest"></a>
+<a id="schema_V2UpdateExporterRequest"></a>
+<a id="tocSv2updateexporterrequest"></a>
+<a id="tocsv2updateexporterrequest"></a>
+
+```json
+{
+  "driver": "string",
+  "config": {}
+}
+
+```
+
+### Properties
+
+*None*
+
 <h2 id="tocS_V2PipelineConfiguration">V2PipelineConfiguration</h2>
 <!-- backwards compatibility -->
 <a id="schemav2pipelineconfiguration"></a>

internal/api/common/mocks_system_controller_test.go

@@ -0,0 +1,34 @@
+package v2
+
+import (
+	"errors"
+	"github.com/formancehq/go-libs/v3/api"
+	ledger "github.com/formancehq/ledger/internal"
+	"github.com/formancehq/ledger/internal/api/common"
+	systemcontroller "github.com/formancehq/ledger/internal/controller/system"
+	"github.com/go-chi/chi/v5"
+	"net/http"
+)
+
+func updateExporter(systemController systemcontroller.Controller) func(w http.ResponseWriter, r *http.Request) {
+	return func(w http.ResponseWriter, r *http.Request) {
+		exporterID := chi.URLParam(r, "exporterID")
+		common.WithBody[ledger.ExporterConfiguration](w, r, func(req ledger.ExporterConfiguration) {
+			err := systemController.UpdateExporter(r.Context(), exporterID, req)
+			if err != nil {
+				switch {
+				case errors.Is(err, systemcontroller.ErrInvalidDriverConfiguration{}):
+					api.BadRequest(w, "VALIDATION", err)
+				case errors.Is(err, systemcontroller.ErrExporterNotFound("")):
+					api.NotFound(w, err)
+				default:
+					api.InternalServerError(w, r, err)
+				}
+				return
+			}
+
+			w.WriteHeader(http.StatusNoContent)
+		})
+	}
+}
+

internal/api/v1/mocks_system_controller_test.go

@@ -0,0 +1,109 @@
+package v2
+
+import (
+	"bytes"
+	"encoding/json"
+	"github.com/formancehq/go-libs/v3/auth"
+	"github.com/formancehq/go-libs/v3/logging"
+	ledger "github.com/formancehq/ledger/internal"
+	systemcontroller "github.com/formancehq/ledger/internal/controller/system"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/google/uuid"
+	"github.com/pkg/errors"
+
+	sharedapi "github.com/formancehq/go-libs/v3/api"
+	"github.com/stretchr/testify/require"
+	"go.uber.org/mock/gomock"
+)
+
+func TestUpdateExporter(t *testing.T) {
+	t.Parallel()
+
+	ctx := logging.TestingContext()
+
+	type testCase struct {
+		name                  string
+		exporterID            string
+		exporterConfiguration ledger.ExporterConfiguration
+		returnError           error
+		expectErrorStatusCode int
+		expectErrorCode       string
+	}
+	for _, testCase := range []testCase{
+		{
+			name:       "nominal",
+			exporterID: uuid.NewString(),
+			exporterConfiguration: ledger.ExporterConfiguration{
+				Driver: "http",
+				Config: json.RawMessage(`{"url":"http://example.com"}`),
+			},
+		},
+		{
+			name:       "invalid driver configuration",
+			exporterID: uuid.NewString(),
+			exporterConfiguration: ledger.ExporterConfiguration{
+				Driver: "http",
+				Config: json.RawMessage(`{"url":"invalid"}`),
+			},
+			returnError:           systemcontroller.NewErrInvalidDriverConfiguration("http", errors.New("invalid config")),
+			expectErrorStatusCode: http.StatusBadRequest,
+			expectErrorCode:       "VALIDATION",
+		},
+		{
+			name:       "exporter not found",
+			exporterID: uuid.NewString(),
+			exporterConfiguration: ledger.ExporterConfiguration{
+				Driver: "http",
+				Config: json.RawMessage(`{"url":"http://example.com"}`),
+			},
+			returnError:           systemcontroller.NewErrExporterNotFound(""),
+			expectErrorStatusCode: http.StatusNotFound,
+			expectErrorCode:       "NOT_FOUND",
+		},
+		{
+			name:       "unknown error",
+			exporterID: uuid.NewString(),
+			exporterConfiguration: ledger.ExporterConfiguration{
+				Driver: "http",
+				Config: json.RawMessage(`{"url":"http://example.com"}`),
+			},
+			expectErrorCode:       "INTERNAL",
+			expectErrorStatusCode: http.StatusInternalServerError,
+			returnError:           errors.New("any error"),
+		},
+	} {
+		testCase := testCase
+		t.Run(testCase.name, func(t *testing.T) {
+			t.Parallel()
+
+			systemController, _ := newTestingSystemController(t, false)
+			systemController.EXPECT().
+				UpdateExporter(gomock.Any(), testCase.exporterID, testCase.exporterConfiguration).
+				Return(testCase.returnError)
+
+			router := NewRouter(systemController, auth.NewNoAuth(), "develop", WithExporters(true))
+
+			data, err := json.Marshal(testCase.exporterConfiguration)
+			require.NoError(t, err)
+
+			req := httptest.NewRequest(http.MethodPut, "/_/exporters/"+testCase.exporterID, bytes.NewBuffer(data))
+			req = req.WithContext(ctx)
+			rsp := httptest.NewRecorder()
+
+			router.ServeHTTP(rsp, req)
+
+			if testCase.expectErrorCode != "" {
+				require.Equal(t, testCase.expectErrorStatusCode, rsp.Code)
+				errorResponse := sharedapi.ErrorResponse{}
+				require.NoError(t, json.NewDecoder(rsp.Body).Decode(&errorResponse))
+				require.Equal(t, testCase.expectErrorCode, errorResponse.ErrorCode)
+			} else {
+				require.Equal(t, http.StatusNoContent, rsp.Code)
+			}
+		})
+	}
+}
+

internal/api/v2/controllers_exporters_update.go

@@ -40,6 +40,7 @@ func NewRouter(
 				router.Route("/exporters", func(router chi.Router) {
 					router.Get("/", listExporters(systemController))
 					router.Get("/{exporterID}", getExporter(systemController))
+					router.Put("/{exporterID}", updateExporter(systemController))
 					router.Delete("/{exporterID}", deleteExporter(systemController))
 					router.Post("/", createExporter(systemController))
 				})

internal/api/v2/controllers_exporters_update_test.go

@@ -26,6 +26,7 @@ import (
 type ReplicationBackend interface {
 	ListExporters(ctx context.Context) (*bunpaginate.Cursor[ledger.Exporter], error)
 	CreateExporter(ctx context.Context, configuration ledger.ExporterConfiguration) (*ledger.Exporter, error)
+	UpdateExporter(ctx context.Context, id string, configuration ledger.ExporterConfiguration) error
 	DeleteExporter(ctx context.Context, id string) error
 	GetExporter(ctx context.Context, id string) (*ledger.Exporter, error)
 
@@ -84,6 +85,13 @@ func (ctrl *DefaultController) CreateExporter(ctx context.Context, configuration
 	return ret, nil
 }
 
+// UpdateExporter can return following errors:
+// * ErrInvalidDriverConfiguration
+// * ErrExporterNotFound
+func (ctrl *DefaultController) UpdateExporter(ctx context.Context, id string, configuration ledger.ExporterConfiguration) error {
+	return ctrl.replicationBackend.UpdateExporter(ctx, id, configuration)
+}
+
 // DeleteExporter can return following errors:
 // ErrExporterNotFound
 func (ctrl *DefaultController) DeleteExporter(ctx context.Context, id string) error {