feat: change metrics names to match semconv (#1038)

gfyrag · web-flow · commit 5b0a0745c887 · 2025-08-22T09:31:13.000Z
* feat: change metrics names to match semconv

* feat: rename some metrics

* chore: set legacy metric name by default :(

* chore: filter metrics to rename
diff --git a/cmd/config.go b/cmd/config.go
@@ -13,7 +13,8 @@ type commonConfig struct {
 	NumscriptInterpreter        bool     `mapstructure:"experimental-numscript-interpreter"`
 	NumscriptInterpreterFlags   []string `mapstructure:"experimental-numscript-interpreter-flags"`
 	ExperimentalFeaturesEnabled bool `mapstructure:"experimental-features"`
-	ExperimentalExporters       bool `mapstructure:"experimental-exporters"`
+	ExperimentalExporters bool `mapstructure:"experimental-exporters"`
+	SemconvMetricsNames   bool `mapstructure:"semconv-metrics-names"`
 }
 
 func decodeCronSchedule(sourceType, destType reflect.Type, value any) (any, error) {
diff --git a/cmd/serve.go b/cmd/serve.go
@@ -5,9 +5,10 @@ import (
 	"github.com/formancehq/go-libs/v3/logging"
 	"github.com/formancehq/ledger/internal/api/common"
 	"github.com/formancehq/ledger/internal/replication"
-	drivers "github.com/formancehq/ledger/internal/replication/drivers"
+	"github.com/formancehq/ledger/internal/replication/drivers"
 	"github.com/formancehq/ledger/internal/replication/drivers/alldrivers"
 	systemstore "github.com/formancehq/ledger/internal/storage/system"
+	"github.com/formancehq/ledger/internal/tracing"
 	"github.com/formancehq/ledger/internal/worker"
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/credentials/insecure"
@@ -69,6 +70,7 @@ const (
 	DefaultPageSizeFlag = "default-page-size"
 	MaxPageSizeFlag     = "max-page-size"
 	WorkerEnabledFlag   = "worker"
+	SemconvMetricsNames = "semconv-metrics-names"
 )
 
 func NewServeCommand() *cobra.Command {
@@ -89,9 +91,7 @@ func NewServeCommand() *cobra.Command {
 
 			options := []fx.Option{
 				fx.NopLogger,
-				otlp.FXModuleFromFlags(cmd, otlp.WithServiceVersion(Version)),
-				otlptraces.FXModuleFromFlags(cmd),
-				otlpmetrics.FXModuleFromFlags(cmd),
+				otlpModule(cmd, cfg.commonConfig),
 				publish.FXModuleFromFlags(cmd, service.IsDebug(cmd)),
 				auth.FXModuleFromFlags(cmd),
 				bunconnect.Module(*connectionOptions, service.IsDebug(cmd)),
@@ -129,15 +129,15 @@ func NewServeCommand() *cobra.Command {
 				}),
 				fx.Decorate(func(
 					params struct {
-						fx.In
+					fx.In
 
-						Handler          chi.Router
-						HealthController *health.HealthController
-						Logger           logging.Logger
+					Handler          chi.Router
+					HealthController *health.HealthController
+					Logger           logging.Logger
 
-						MeterProvider *metric.MeterProvider         `optional:"true"`
-						Exporter      *otlpmetrics.InMemoryExporter `optional:"true"`
-					},
+					MeterProvider *metric.MeterProvider         `optional:"true"`
+					Exporter      *otlpmetrics.InMemoryExporter `optional:"true"`
+				},
 				) chi.Router {
 					return assembleFinalRouter(
 						service.IsDebug(cmd),
@@ -184,6 +184,7 @@ func NewServeCommand() *cobra.Command {
 	cmd.Flags().Bool(NumscriptInterpreterFlag, false, "Enable experimental numscript rewrite")
 	cmd.Flags().String(NumscriptInterpreterFlagsToPass, "", "Feature flags to pass to the experimental numscript interpreter")
 	cmd.Flags().String(WorkerGRPCAddressFlag, "localhost:8081", "GRPC address")
+	cmd.Flags().Bool(SemconvMetricsNames, false, "Use semconv metrics names (recommended)")
 
 	addWorkerFlags(cmd)
 	bunconnect.AddFlags(cmd.Flags())
@@ -245,3 +246,23 @@ func assembleFinalRouter(
 
 	return wrappedRouter
 }
+
+func otlpModule(cmd *cobra.Command, cfg commonConfig) fx.Option {
+	return fx.Options(
+		otlp.FXModuleFromFlags(cmd, otlp.WithServiceVersion(Version)),
+		otlptraces.FXModuleFromFlags(cmd),
+		otlpmetrics.ProvideMetricsProviderOption(func() metric.Option {
+			return metric.WithView(func(instrument metric.Instrument) (metric.Stream, bool) {
+				if cfg.SemconvMetricsNames {
+					return metric.Stream{}, false
+				}
+				return metric.Stream{
+					Name:        tracing.LegacyMetricsName(instrument.Name),
+					Description: instrument.Description,
+					Unit:        instrument.Unit,
+				}, true
+			})
+		}),
+		otlpmetrics.FXModuleFromFlags(cmd),
+	)
+}
diff --git a/cmd/worker.go b/cmd/worker.go
@@ -3,7 +3,6 @@ package cmd
 import (
 	"fmt"
 	"github.com/formancehq/go-libs/v3/bun/bunconnect"
-	"github.com/formancehq/go-libs/v3/otlp"
 	"github.com/formancehq/go-libs/v3/otlp/otlpmetrics"
 	"github.com/formancehq/go-libs/v3/otlp/otlptraces"
 	"github.com/formancehq/go-libs/v3/service"
@@ -78,9 +77,7 @@ func NewWorkerCommand() *cobra.Command {
 
 			return service.New(cmd.OutOrStdout(),
 				fx.NopLogger,
-				otlp.FXModuleFromFlags(cmd),
-				otlptraces.FXModuleFromFlags(cmd),
-				otlpmetrics.FXModuleFromFlags(cmd),
+				otlpModule(cmd, cfg.commonConfig),
 				bunconnect.Module(*connectionOptions, service.IsDebug(cmd)),
 				storage.NewFXModule(storage.ModuleConfig{}),
 				drivers.NewFXModule(),
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -43,7 +43,7 @@ services:
       - "16686:16686/tcp"
 
   worker:
-    image: golang:1.23-alpine
+    image: golang:1.24-alpine
     entrypoint: go run main.go worker
     volumes:
       - .:/src
diff --git a/internal/controller/ledger/controller_default.go b/internal/controller/ledger/controller_default.go
@@ -120,11 +120,11 @@ func NewDefaultController(
 	}
 
 	var err error
-	ret.executeMachineHistogram, err = ret.meter.Int64Histogram("numscript.run")
+	ret.executeMachineHistogram, err = ret.meter.Int64Histogram("controller.numscript_run")
 	if err != nil {
 		panic(err)
 	}
-	ret.deadLockCounter, err = ret.meter.Int64Counter("deadlocks")
+	ret.deadLockCounter, err = ret.meter.Int64Counter("controller.deadlocks")
 	if err != nil {
 		panic(err)
 	}
diff --git a/internal/controller/ledger/controller_with_traces.go b/internal/controller/ledger/controller_with_traces.go
@@ -55,95 +55,95 @@ func NewControllerWithTraces(underlying Controller, tracer trace.Tracer, meter m
 	}
 
 	var err error
-	ret.beginTxHistogram, err = meter.Int64Histogram("BeginTX")
+	ret.beginTxHistogram, err = meter.Int64Histogram("controller.begin_tx")
 	if err != nil {
 		panic(err)
 	}
-	ret.listTransactionsHistogram, err = meter.Int64Histogram("ListTransactions")
+	ret.listTransactionsHistogram, err = meter.Int64Histogram("controller.list_transactions")
 	if err != nil {
 		panic(err)
 	}
-	ret.commitHistogram, err = meter.Int64Histogram("Commit")
+	ret.commitHistogram, err = meter.Int64Histogram("controller.commit")
 	if err != nil {
 		panic(err)
 	}
-	ret.rollbackHistogram, err = meter.Int64Histogram("Rollback")
+	ret.rollbackHistogram, err = meter.Int64Histogram("controller.rollback")
 	if err != nil {
 		panic(err)
 	}
-	ret.countTransactionsHistogram, err = meter.Int64Histogram("CountTransactions")
+	ret.countTransactionsHistogram, err = meter.Int64Histogram("controller.count_transactions")
 	if err != nil {
 		panic(err)
 	}
-	ret.getTransactionHistogram, err = meter.Int64Histogram("GetTransaction")
+	ret.getTransactionHistogram, err = meter.Int64Histogram("controller.get_transaction")
 	if err != nil {
 		panic(err)
 	}
-	ret.countAccountsHistogram, err = meter.Int64Histogram("CountAccounts")
+	ret.countAccountsHistogram, err = meter.Int64Histogram("controller.count_accounts")
 	if err != nil {
 		panic(err)
 	}
-	ret.listAccountsHistogram, err = meter.Int64Histogram("ListAccounts")
+	ret.listAccountsHistogram, err = meter.Int64Histogram("controller.list_accounts")
 	if err != nil {
 		panic(err)
 	}
-	ret.getAccountHistogram, err = meter.Int64Histogram("GetAccount")
+	ret.getAccountHistogram, err = meter.Int64Histogram("controller.get_account")
 	if err != nil {
 		panic(err)
 	}
-	ret.getAggregatedBalancesHistogram, err = meter.Int64Histogram("GetAggregatedBalances")
+	ret.getAggregatedBalancesHistogram, err = meter.Int64Histogram("controller.get_aggregated_balances")
 	if err != nil {
 		panic(err)
 	}
-	ret.listLogsHistogram, err = meter.Int64Histogram("ListLogs")
+	ret.listLogsHistogram, err = meter.Int64Histogram("controller.list_logs")
 	if err != nil {
 		panic(err)
 	}
-	ret.importHistogram, err = meter.Int64Histogram("Import")
+	ret.importHistogram, err = meter.Int64Histogram("controller.import")
 	if err != nil {
 		panic(err)
 	}
-	ret.exportHistogram, err = meter.Int64Histogram("Export")
+	ret.exportHistogram, err = meter.Int64Histogram("controller.export")
 	if err != nil {
 		panic(err)
 	}
-	ret.isDatabaseUpToDateHistogram, err = meter.Int64Histogram("IsDatabaseUpToDate")
+	ret.isDatabaseUpToDateHistogram, err = meter.Int64Histogram("controller.is_database_up_to_date")
 	if err != nil {
 		panic(err)
 	}
-	ret.getVolumesWithBalancesHistogram, err = meter.Int64Histogram("GetVolumesWithBalances")
+	ret.getVolumesWithBalancesHistogram, err = meter.Int64Histogram("controller.get_volumes_with_balances")
 	if err != nil {
 		panic(err)
 	}
-	ret.getStatsHistogram, err = meter.Int64Histogram("GetStats")
+	ret.getStatsHistogram, err = meter.Int64Histogram("controller.get_stats")
 	if err != nil {
 		panic(err)
 	}
-	ret.createTransactionHistogram, err = meter.Int64Histogram("CreateTransaction")
+	ret.createTransactionHistogram, err = meter.Int64Histogram("controller.create_transaction")
 	if err != nil {
 		panic(err)
 	}
-	ret.revertTransactionHistogram, err = meter.Int64Histogram("RevertTransaction")
+	ret.revertTransactionHistogram, err = meter.Int64Histogram("controller.revert_transaction")
 	if err != nil {
 		panic(err)
 	}
-	ret.saveTransactionMetadataHistogram, err = meter.Int64Histogram("SaveTransactionMetadata")
+	ret.saveTransactionMetadataHistogram, err = meter.Int64Histogram("controller.save_transaction_metadata")
 	if err != nil {
 		panic(err)
 	}
-	ret.saveAccountMetadataHistogram, err = meter.Int64Histogram("SaveAccountMetadata")
+	ret.saveAccountMetadataHistogram, err = meter.Int64Histogram("controller.save_account_metadata")
 	if err != nil {
 		panic(err)
 	}
-	ret.deleteTransactionMetadataHistogram, err = meter.Int64Histogram("DeleteTransactionMetadata")
+	ret.deleteTransactionMetadataHistogram, err = meter.Int64Histogram("controller.delete_transaction_metadata")
 	if err != nil {
 		panic(err)
 	}
-	ret.deleteAccountMetadataHistogram, err = meter.Int64Histogram("DeleteAccountMetadata")
+	ret.deleteAccountMetadataHistogram, err = meter.Int64Histogram("controller.delete_account_metadata")
 	if err != nil {
 		panic(err)
 	}
-	ret.lockLedgerHistogram, err = meter.Int64Histogram("LockLedger")
+	ret.lockLedgerHistogram, err = meter.Int64Histogram("controller.lock_ledger")
 	if err != nil {
 		panic(err)
 	}
diff --git a/internal/storage/ledger/store.go b/internal/storage/ledger/store.go
@@ -174,77 +174,77 @@ func New(db bun.IDB, bucket bucket.Bucket, l ledger.Ledger, opts ...Option) *Sto
 	}
 
 	var err error
-	ret.checkBucketSchemaHistogram, err = ret.meter.Int64Histogram("store.checkBucketSchema")
+		ret.checkBucketSchemaHistogram, err = ret.meter.Int64Histogram("store.check_bucket_schema")
 	if err != nil {
 		panic(err)
 	}
 
-	ret.checkLedgerSchemaHistogram, err = ret.meter.Int64Histogram("store.checkLedgerSchema")
+	ret.checkLedgerSchemaHistogram, err = ret.meter.Int64Histogram("store.check_ledger_schema")
 	if err != nil {
 		panic(err)
 	}
 
-	ret.updateAccountsMetadataHistogram, err = ret.meter.Int64Histogram("store.updateAccountsMetadata")
+	ret.updateAccountsMetadataHistogram, err = ret.meter.Int64Histogram("store.update_accounts_metadata")
 	if err != nil {
 		panic(err)
 	}
 
-	ret.deleteAccountMetadataHistogram, err = ret.meter.Int64Histogram("store.deleteAccountMetadata")
+	ret.deleteAccountMetadataHistogram, err = ret.meter.Int64Histogram("store.delete_account_metadata")
 	if err != nil {
 		panic(err)
 	}
 
-	ret.upsertAccountsHistogram, err = ret.meter.Int64Histogram("store.upsertAccounts")
+	ret.upsertAccountsHistogram, err = ret.meter.Int64Histogram("store.upsert_accounts")
 	if err != nil {
 		panic(err)
 	}
 
-	ret.getBalancesHistogram, err = ret.meter.Int64Histogram("store.getBalances")
+	ret.getBalancesHistogram, err = ret.meter.Int64Histogram("store.get_balances")
 	if err != nil {
 		panic(err)
 	}
 
-	ret.insertLogHistogram, err = ret.meter.Int64Histogram("store.insertLog")
+	ret.insertLogHistogram, err = ret.meter.Int64Histogram("store.insert_log")
 	if err != nil {
 		panic(err)
 	}
 
-	ret.readLogWithIdempotencyKeyHistogram, err = ret.meter.Int64Histogram("store.readLogWithIdempotencyKey")
+	ret.readLogWithIdempotencyKeyHistogram, err = ret.meter.Int64Histogram("store.read_log_with_idempotency_key")
 	if err != nil {
 		panic(err)
 	}
 
-	ret.insertMovesHistogram, err = ret.meter.Int64Histogram("store.insertMoves")
+	ret.insertMovesHistogram, err = ret.meter.Int64Histogram("store.insert_moves")
 	if err != nil {
 		panic(err)
 	}
 
-	ret.insertTransactionHistogram, err = ret.meter.Int64Histogram("store.insertTransaction")
+	ret.insertTransactionHistogram, err = ret.meter.Int64Histogram("store.insert_transaction")
 	if err != nil {
 		panic(err)
 	}
 
-	ret.revertTransactionHistogram, err = ret.meter.Int64Histogram("store.revertTransaction")
+	ret.revertTransactionHistogram, err = ret.meter.Int64Histogram("store.revert_transaction")
 	if err != nil {
 		panic(err)
 	}
 
-	ret.updateTransactionMetadataHistogram, err = ret.meter.Int64Histogram("store.updateTransactionMetadata")
+	ret.updateTransactionMetadataHistogram, err = ret.meter.Int64Histogram("store.update_transaction_metadata")
 	if err != nil {
 		panic(err)
 	}
 
-	ret.deleteTransactionMetadataHistogram, err = ret.meter.Int64Histogram("store.deleteTransactionMetadata")
+	ret.deleteTransactionMetadataHistogram, err = ret.meter.Int64Histogram("store.delete_transaction_metadata")
 	if err != nil {
 		panic(err)
 	}
 
-	ret.updateBalancesHistogram, err = ret.meter.Int64Histogram("store.updateBalances")
+	ret.updateBalancesHistogram, err = ret.meter.Int64Histogram("store.update_balances")
 	if err != nil {
 		panic(err)
 	}
 
-	ret.getVolumesWithBalancesHistogram, err = ret.meter.Int64Histogram("store.getVolumesWithBalances")
+	ret.getVolumesWithBalancesHistogram, err = ret.meter.Int64Histogram("store.get_volumes_with_balances")
 	if err != nil {
 		panic(err)
 	}
diff --git a/internal/tracing/tracing.go b/internal/tracing/tracing.go

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,8 @@ type commonConfig struct {`
`13`	`13`	NumscriptInterpreter bool `mapstructure:"experimental-numscript-interpreter"`
`14`	`14`	NumscriptInterpreterFlags []string `mapstructure:"experimental-numscript-interpreter-flags"`
`15`	`15`	ExperimentalFeaturesEnabled bool `mapstructure:"experimental-features"`
`16`		- ExperimentalExporters bool `mapstructure:"experimental-exporters"`
	`16`	+ ExperimentalExporters bool `mapstructure:"experimental-exporters"`
	`17`	+ SemconvMetricsNames bool `mapstructure:"semconv-metrics-names"`
`17`	`18`	`}`
`18`	`19`
`19`	`20`	`func decodeCronSchedule(sourceType, destType reflect.Type, value any) (any, error) {`
Original file line number	Diff line number	Diff line change
`@@ -120,11 +120,11 @@ func NewDefaultController(`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`var err error`
`123`		`- ret.executeMachineHistogram, err = ret.meter.Int64Histogram("numscript.run")`
	`123`	`+ ret.executeMachineHistogram, err = ret.meter.Int64Histogram("controller.numscript_run")`
`124`	`124`	`if err != nil {`
`125`	`125`	`panic(err)`
`126`	`126`	`}`
`127`		`- ret.deadLockCounter, err = ret.meter.Int64Counter("deadlocks")`
	`127`	`+ ret.deadLockCounter, err = ret.meter.Int64Counter("controller.deadlocks")`
`128`	`128`	`if err != nil {`
`129`	`129`	`panic(err)`
`130`	`130`	`}`
Original file line number	Diff line number	Diff line change
`@@ -55,95 +55,95 @@ func NewControllerWithTraces(underlying Controller, tracer trace.Tracer, meter m`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`var err error`
`58`		`- ret.beginTxHistogram, err = meter.Int64Histogram("BeginTX")`
	`58`	`+ ret.beginTxHistogram, err = meter.Int64Histogram("controller.begin_tx")`
`59`	`59`	`if err != nil {`
`60`	`60`	`panic(err)`
`61`	`61`	`}`
`62`		`- ret.listTransactionsHistogram, err = meter.Int64Histogram("ListTransactions")`
	`62`	`+ ret.listTransactionsHistogram, err = meter.Int64Histogram("controller.list_transactions")`
`63`	`63`	`if err != nil {`
`64`	`64`	`panic(err)`
`65`	`65`	`}`
`66`		`- ret.commitHistogram, err = meter.Int64Histogram("Commit")`
	`66`	`+ ret.commitHistogram, err = meter.Int64Histogram("controller.commit")`
`67`	`67`	`if err != nil {`
`68`	`68`	`panic(err)`
`69`	`69`	`}`
`70`		`- ret.rollbackHistogram, err = meter.Int64Histogram("Rollback")`
	`70`	`+ ret.rollbackHistogram, err = meter.Int64Histogram("controller.rollback")`
`71`	`71`	`if err != nil {`
`72`	`72`	`panic(err)`
`73`	`73`	`}`
`74`		`- ret.countTransactionsHistogram, err = meter.Int64Histogram("CountTransactions")`
	`74`	`+ ret.countTransactionsHistogram, err = meter.Int64Histogram("controller.count_transactions")`
`75`	`75`	`if err != nil {`
`76`	`76`	`panic(err)`
`77`	`77`	`}`
`78`		`- ret.getTransactionHistogram, err = meter.Int64Histogram("GetTransaction")`
	`78`	`+ ret.getTransactionHistogram, err = meter.Int64Histogram("controller.get_transaction")`
`79`	`79`	`if err != nil {`
`80`	`80`	`panic(err)`
`81`	`81`	`}`
`82`		`- ret.countAccountsHistogram, err = meter.Int64Histogram("CountAccounts")`
	`82`	`+ ret.countAccountsHistogram, err = meter.Int64Histogram("controller.count_accounts")`
`83`	`83`	`if err != nil {`
`84`	`84`	`panic(err)`
`85`	`85`	`}`
`86`		`- ret.listAccountsHistogram, err = meter.Int64Histogram("ListAccounts")`
	`86`	`+ ret.listAccountsHistogram, err = meter.Int64Histogram("controller.list_accounts")`
`87`	`87`	`if err != nil {`
`88`	`88`	`panic(err)`
`89`	`89`	`}`
`90`		`- ret.getAccountHistogram, err = meter.Int64Histogram("GetAccount")`
	`90`	`+ ret.getAccountHistogram, err = meter.Int64Histogram("controller.get_account")`
`91`	`91`	`if err != nil {`
`92`	`92`	`panic(err)`
`93`	`93`	`}`
`94`		`- ret.getAggregatedBalancesHistogram, err = meter.Int64Histogram("GetAggregatedBalances")`
	`94`	`+ ret.getAggregatedBalancesHistogram, err = meter.Int64Histogram("controller.get_aggregated_balances")`
`95`	`95`	`if err != nil {`
`96`	`96`	`panic(err)`
`97`	`97`	`}`
`98`		`- ret.listLogsHistogram, err = meter.Int64Histogram("ListLogs")`
	`98`	`+ ret.listLogsHistogram, err = meter.Int64Histogram("controller.list_logs")`
`99`	`99`	`if err != nil {`
`100`	`100`	`panic(err)`
`101`	`101`	`}`
`102`		`- ret.importHistogram, err = meter.Int64Histogram("Import")`
	`102`	`+ ret.importHistogram, err = meter.Int64Histogram("controller.import")`
`103`	`103`	`if err != nil {`
`104`	`104`	`panic(err)`
`105`	`105`	`}`
`106`		`- ret.exportHistogram, err = meter.Int64Histogram("Export")`
	`106`	`+ ret.exportHistogram, err = meter.Int64Histogram("controller.export")`
`107`	`107`	`if err != nil {`
`108`	`108`	`panic(err)`
`109`	`109`	`}`
`110`		`- ret.isDatabaseUpToDateHistogram, err = meter.Int64Histogram("IsDatabaseUpToDate")`
	`110`	`+ ret.isDatabaseUpToDateHistogram, err = meter.Int64Histogram("controller.is_database_up_to_date")`
`111`	`111`	`if err != nil {`
`112`	`112`	`panic(err)`
`113`	`113`	`}`
`114`		`- ret.getVolumesWithBalancesHistogram, err = meter.Int64Histogram("GetVolumesWithBalances")`
	`114`	`+ ret.getVolumesWithBalancesHistogram, err = meter.Int64Histogram("controller.get_volumes_with_balances")`
`115`	`115`	`if err != nil {`
`116`	`116`	`panic(err)`
`117`	`117`	`}`
`118`		`- ret.getStatsHistogram, err = meter.Int64Histogram("GetStats")`
	`118`	`+ ret.getStatsHistogram, err = meter.Int64Histogram("controller.get_stats")`
`119`	`119`	`if err != nil {`
`120`	`120`	`panic(err)`
`121`	`121`	`}`
`122`		`- ret.createTransactionHistogram, err = meter.Int64Histogram("CreateTransaction")`
	`122`	`+ ret.createTransactionHistogram, err = meter.Int64Histogram("controller.create_transaction")`
`123`	`123`	`if err != nil {`
`124`	`124`	`panic(err)`
`125`	`125`	`}`
`126`		`- ret.revertTransactionHistogram, err = meter.Int64Histogram("RevertTransaction")`
	`126`	`+ ret.revertTransactionHistogram, err = meter.Int64Histogram("controller.revert_transaction")`
`127`	`127`	`if err != nil {`
`128`	`128`	`panic(err)`
`129`	`129`	`}`
`130`		`- ret.saveTransactionMetadataHistogram, err = meter.Int64Histogram("SaveTransactionMetadata")`
	`130`	`+ ret.saveTransactionMetadataHistogram, err = meter.Int64Histogram("controller.save_transaction_metadata")`
`131`	`131`	`if err != nil {`
`132`	`132`	`panic(err)`
`133`	`133`	`}`
`134`		`- ret.saveAccountMetadataHistogram, err = meter.Int64Histogram("SaveAccountMetadata")`
	`134`	`+ ret.saveAccountMetadataHistogram, err = meter.Int64Histogram("controller.save_account_metadata")`
`135`	`135`	`if err != nil {`
`136`	`136`	`panic(err)`
`137`	`137`	`}`
`138`		`- ret.deleteTransactionMetadataHistogram, err = meter.Int64Histogram("DeleteTransactionMetadata")`
	`138`	`+ ret.deleteTransactionMetadataHistogram, err = meter.Int64Histogram("controller.delete_transaction_metadata")`
`139`	`139`	`if err != nil {`
`140`	`140`	`panic(err)`
`141`	`141`	`}`
`142`		`- ret.deleteAccountMetadataHistogram, err = meter.Int64Histogram("DeleteAccountMetadata")`
	`142`	`+ ret.deleteAccountMetadataHistogram, err = meter.Int64Histogram("controller.delete_account_metadata")`
`143`	`143`	`if err != nil {`
`144`	`144`	`panic(err)`
`145`	`145`	`}`
`146`		`- ret.lockLedgerHistogram, err = meter.Int64Histogram("LockLedger")`
	`146`	`+ ret.lockLedgerHistogram, err = meter.Int64Histogram("controller.lock_ledger")`
`147`	`147`	`if err != nil {`
`148`	`148`	`panic(err)`
`149`	`149`	`}`
Original file line number	Diff line number	Diff line change
`@@ -174,77 +174,77 @@ func New(db bun.IDB, bucket bucket.Bucket, l ledger.Ledger, opts ...Option) *Sto`
`174`	`174`	`}`
`175`	`175`
`176`	`176`	`var err error`
`177`		`- ret.checkBucketSchemaHistogram, err = ret.meter.Int64Histogram("store.checkBucketSchema")`
	`177`	`+ ret.checkBucketSchemaHistogram, err = ret.meter.Int64Histogram("store.check_bucket_schema")`
`178`	`178`	`if err != nil {`
`179`	`179`	`panic(err)`
`180`	`180`	`}`
`181`	`181`
`182`		`- ret.checkLedgerSchemaHistogram, err = ret.meter.Int64Histogram("store.checkLedgerSchema")`
	`182`	`+ ret.checkLedgerSchemaHistogram, err = ret.meter.Int64Histogram("store.check_ledger_schema")`
`183`	`183`	`if err != nil {`
`184`	`184`	`panic(err)`
`185`	`185`	`}`
`186`	`186`
`187`		`- ret.updateAccountsMetadataHistogram, err = ret.meter.Int64Histogram("store.updateAccountsMetadata")`
	`187`	`+ ret.updateAccountsMetadataHistogram, err = ret.meter.Int64Histogram("store.update_accounts_metadata")`
`188`	`188`	`if err != nil {`
`189`	`189`	`panic(err)`
`190`	`190`	`}`
`191`	`191`
`192`		`- ret.deleteAccountMetadataHistogram, err = ret.meter.Int64Histogram("store.deleteAccountMetadata")`
	`192`	`+ ret.deleteAccountMetadataHistogram, err = ret.meter.Int64Histogram("store.delete_account_metadata")`
`193`	`193`	`if err != nil {`
`194`	`194`	`panic(err)`
`195`	`195`	`}`
`196`	`196`
`197`		`- ret.upsertAccountsHistogram, err = ret.meter.Int64Histogram("store.upsertAccounts")`
	`197`	`+ ret.upsertAccountsHistogram, err = ret.meter.Int64Histogram("store.upsert_accounts")`
`198`	`198`	`if err != nil {`
`199`	`199`	`panic(err)`
`200`	`200`	`}`
`201`	`201`
`202`		`- ret.getBalancesHistogram, err = ret.meter.Int64Histogram("store.getBalances")`
	`202`	`+ ret.getBalancesHistogram, err = ret.meter.Int64Histogram("store.get_balances")`
`203`	`203`	`if err != nil {`
`204`	`204`	`panic(err)`
`205`	`205`	`}`
`206`	`206`
`207`		`- ret.insertLogHistogram, err = ret.meter.Int64Histogram("store.insertLog")`
	`207`	`+ ret.insertLogHistogram, err = ret.meter.Int64Histogram("store.insert_log")`
`208`	`208`	`if err != nil {`
`209`	`209`	`panic(err)`
`210`	`210`	`}`
`211`	`211`
`212`		`- ret.readLogWithIdempotencyKeyHistogram, err = ret.meter.Int64Histogram("store.readLogWithIdempotencyKey")`
	`212`	`+ ret.readLogWithIdempotencyKeyHistogram, err = ret.meter.Int64Histogram("store.read_log_with_idempotency_key")`
`213`	`213`	`if err != nil {`
`214`	`214`	`panic(err)`
`215`	`215`	`}`
`216`	`216`
`217`		`- ret.insertMovesHistogram, err = ret.meter.Int64Histogram("store.insertMoves")`
	`217`	`+ ret.insertMovesHistogram, err = ret.meter.Int64Histogram("store.insert_moves")`
`218`	`218`	`if err != nil {`
`219`	`219`	`panic(err)`
`220`	`220`	`}`
`221`	`221`
`222`		`- ret.insertTransactionHistogram, err = ret.meter.Int64Histogram("store.insertTransaction")`
	`222`	`+ ret.insertTransactionHistogram, err = ret.meter.Int64Histogram("store.insert_transaction")`
`223`	`223`	`if err != nil {`
`224`	`224`	`panic(err)`
`225`	`225`	`}`
`226`	`226`
`227`		`- ret.revertTransactionHistogram, err = ret.meter.Int64Histogram("store.revertTransaction")`
	`227`	`+ ret.revertTransactionHistogram, err = ret.meter.Int64Histogram("store.revert_transaction")`
`228`	`228`	`if err != nil {`
`229`	`229`	`panic(err)`
`230`	`230`	`}`
`231`	`231`
`232`		`- ret.updateTransactionMetadataHistogram, err = ret.meter.Int64Histogram("store.updateTransactionMetadata")`
	`232`	`+ ret.updateTransactionMetadataHistogram, err = ret.meter.Int64Histogram("store.update_transaction_metadata")`
`233`	`233`	`if err != nil {`
`234`	`234`	`panic(err)`
`235`	`235`	`}`
`236`	`236`
`237`		`- ret.deleteTransactionMetadataHistogram, err = ret.meter.Int64Histogram("store.deleteTransactionMetadata")`
	`237`	`+ ret.deleteTransactionMetadataHistogram, err = ret.meter.Int64Histogram("store.delete_transaction_metadata")`
`238`	`238`	`if err != nil {`
`239`	`239`	`panic(err)`
`240`	`240`	`}`
`241`	`241`
`242`		`- ret.updateBalancesHistogram, err = ret.meter.Int64Histogram("store.updateBalances")`
	`242`	`+ ret.updateBalancesHistogram, err = ret.meter.Int64Histogram("store.update_balances")`
`243`	`243`	`if err != nil {`
`244`	`244`	`panic(err)`
`245`	`245`	`}`
`246`	`246`
`247`		`- ret.getVolumesWithBalancesHistogram, err = ret.meter.Int64Histogram("store.getVolumesWithBalances")`
	`247`	`+ ret.getVolumesWithBalancesHistogram, err = ret.meter.Int64Histogram("store.get_volumes_with_balances")`
`248`	`248`	`if err != nil {`
`249`	`249`	`panic(err)`
`250`	`250`	`}`