feat: hide textual errors on internal server errors

Author: gfyrag

internal/api/common/errors.go

@@ -3,7 +3,9 @@ package common
 import (
 	"errors"
 	"github.com/formancehq/go-libs/v2/api"
+	"github.com/formancehq/go-libs/v2/logging"
 	"github.com/formancehq/go-libs/v2/platform/postgres"
+	"go.opentelemetry.io/otel/trace"
 	"net/http"
 )
 
@@ -31,6 +33,15 @@ func HandleCommonErrors(w http.ResponseWriter, r *http.Request, err error) {
 	case errors.Is(err, postgres.ErrTooManyClient{}):
 		api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
 	default:
-		api.InternalServerError(w, r, err)
+		InternalServerError(w, r, err)
 	}
 }
+
+func InternalServerError(w http.ResponseWriter, r *http.Request, err error) {
+	span := trace.SpanFromContext(r.Context())
+	if span != nil {
+		span.RecordError(err)
+	}
+	logging.FromContext(r.Context()).Error(err)
+	api.WriteErrorResponse(w, http.StatusInternalServerError, api.ErrorInternal, errors.New("Internal error. Consult logs/traces to have more details."))
+}

internal/api/common/middleware_resolver.go

@@ -40,7 +40,7 @@ func LedgerMiddleware(
 				case postgres.IsNotFoundError(err):
 					api.WriteErrorResponse(w, http.StatusNotFound, "LEDGER_NOT_FOUND", err)
 				default:
-					api.InternalServerError(w, r, err)
+					InternalServerError(w, r, err)
 				}
 				return
 			}
@@ -65,7 +65,7 @@ func LedgerMiddleware(
 			if !excluded {
 				isUpToDate, err := l.IsDatabaseUpToDate(ctx)
 				if err != nil {
-					api.InternalServerError(w, r, err)
+					InternalServerError(w, r, err)
 					return
 				}
 				if !isUpToDate {

internal/api/v1/middleware_auto_create_ledger.go

@@ -26,7 +26,7 @@ func autoCreateMiddleware(backend system.Controller, tracer trace.Tracer) func(h
 			ledgerName := chi.URLParam(r, "ledger")
 			if _, err := backend.GetLedger(ctx, ledgerName); err != nil {
 				if !postgres.IsNotFoundError(err) {
-					api.InternalServerError(w, r, err)
+					common.InternalServerError(w, r, err)
 					return
 				}
 
@@ -37,7 +37,7 @@ func autoCreateMiddleware(backend system.Controller, tracer trace.Tracer) func(h
 					case errors.Is(err, ledger.ErrInvalidLedgerName{}):
 						api.BadRequest(w, common.ErrValidation, err)
 					default:
-						api.InternalServerError(w, r, err)
+						common.InternalServerError(w, r, err)
 					}
 					return
 				}

internal/api/v2/controllers_bulk.go

@@ -43,7 +43,7 @@ func bulkHandler(bulkerFactory bulking.BulkerFactory, bulkHandlerFactories map[s
 			},
 		)
 		if err != nil {
-			api.InternalServerError(w, r, err)
+			common.InternalServerError(w, r, err)
 			return
 		}
 

internal/api/v2/controllers_ledgers_create.go

@@ -20,7 +20,7 @@ func createLedger(systemController system.Controller) http.HandlerFunc {
 		configuration := ledger.Configuration{}
 		data, err := io.ReadAll(r.Body)
 		if err != nil && !errors.Is(err, io.EOF) {
-			api.InternalServerError(w, r, err)
+			common.InternalServerError(w, r, err)
 			return
 		}
 

internal/api/v2/controllers_logs_import.go

@@ -36,14 +36,14 @@ func importLogs(w http.ResponseWriter, r *http.Request) {
 				close(stream)
 				break
 			} else {
-				api.InternalServerError(w, r, err)
+				common.InternalServerError(w, r, err)
 				return
 			}
 		}
 		select {
 		case stream <- l:
 		case <-r.Context().Done():
-			api.InternalServerError(w, r, r.Context().Err())
+			common.InternalServerError(w, r, r.Context().Err())
 			return
 		case err := <-errChan:
 			handleError(err)
@@ -57,7 +57,7 @@ func importLogs(w http.ResponseWriter, r *http.Request) {
 			return
 		}
 	case <-r.Context().Done():
-		api.InternalServerError(w, r, r.Context().Err())
+		common.InternalServerError(w, r, r.Context().Err())
 		return
 	}