chore: simplify

Author: gfyrag

internal/storage/bucket/bucket.go

@@ -16,6 +16,7 @@ type Bucket interface {
 	IsUpToDate(ctx context.Context) (bool, error)
 	GetMigrationsInfo(ctx context.Context) ([]migrations.Info, error)
 	IsInitialized(context.Context) (bool, error)
+	WithDB(bun.IDB) Bucket
 }
 
 type Factory interface {

internal/storage/bucket/default_bucket.go

@@ -79,6 +79,11 @@ func (b *DefaultBucket) AddLedger(ctx context.Context, l ledger.Ledger) error {
 	return nil
 }
 
+func (b *DefaultBucket) WithDB(db bun.IDB) Bucket {
+	b.db = db
+	return b
+}
+
 func NewDefault(db bun.IDB, tracer trace.Tracer, name string) *DefaultBucket {
 	return &DefaultBucket{
 		db:   db,

internal/storage/driver/driver.go

@@ -76,7 +76,7 @@ func (d *Driver) CreateLedger(ctx context.Context, l *ledger.Ledger) (*ledgersto
 			}
 		}
 
-		ret = d.ledgerStoreFactory.Create(b, *l)
+		ret = d.ledgerStoreFactory.Create(b.WithDB(d.db), *l)
 
 		return nil
 	})

internal/storage/ledger/balances.go

@@ -2,7 +2,6 @@ package ledger
 
 import (
 	"context"
-	"github.com/formancehq/ledger/internal/storage/bucket"
 	"math/big"
 	"slices"
 	"strings"
@@ -16,8 +15,7 @@ import (
 )
 
 func (store *Store) GetBalances(ctx context.Context, query ledgercontroller.BalanceQuery) (ledgercontroller.Balances, error) {
-	isUpToDate, err := bucket.NewDefault(store.db, store.tracer, store.ledger.Bucket).
-		IsUpToDate(ctx)
+	isUpToDate, err := store.bucket.IsUpToDate(ctx)
 	if err != nil {
 		return nil, err
 	}