feat(version): wrote to the existing package.json after the order change in the js language plugin

BREAKING CHANGE: the plugin now expects to be executed after the `package.json` already exists,
which was not reality before v6.0.0-alpha.1 of `@form8ion/javascript`

Author: travi

package-lock.json

@@ -88,7 +88,7 @@
   "dependencies": {
     "@form8ion/core": "^1.4.2",
     "@form8ion/github-workflows-core": "1.0.0",
-    "@form8ion/javascript-core": "^5.0.0",
+    "@form8ion/javascript-core": "^5.2.0",
     "deepmerge": "^4.2.2",
     "js-yaml": "^4.1.0"
   }

package.json

@@ -33,7 +33,7 @@ suite('commit-convention scaffolder', () => {
     sandbox.stub(semanticReleaseScaffolder, 'default');
 
     commitizenScaffolder.default.withArgs({projectRoot}).resolves(commitizenResults);
-    semanticReleaseScaffolder.default.returns(semanticReleaseResults);
+    semanticReleaseScaffolder.default.withArgs({projectRoot}).resolves(semanticReleaseResults);
   });
 
   teardown(() => sandbox.restore());
@@ -45,6 +45,7 @@ suite('commit-convention scaffolder', () => {
   test('that only semantic-release is configured for a sub-package', async () => {
     assert.deepEqual(
       await scaffoldCommitConvention({
+        projectRoot,
         pathWithinParent: any.string(),
         projectType: publishedProjectType
       }),

src/scaffolder-test.js

@@ -7,7 +7,7 @@ import scaffoldCommitlint from './commitlint';
 
 export default async function ({projectRoot, projectType, configs, pathWithinParent}) {
   const detailsForProjectsPublishedToARegistry = [projectTypes.PACKAGE, projectTypes.CLI].includes(projectType)
-    ? scaffoldSemanticRelease()
+    ? await scaffoldSemanticRelease({projectRoot})
     : {};
 
   if (pathWithinParent) return detailsForProjectsPublishedToARegistry;

src/scaffolder.js

@@ -1,13 +1,27 @@
+import * as jsCore from '@form8ion/javascript-core';
+
 import {assert} from 'chai';
+import sinon from 'sinon';
+import any from '@travi/any';
 
 import scaffoldSemanticRelease from './scaffolder';
 
 suite('semantic-release scaffolder', () => {
+  let sandbox;
+  const projectRoot = any.string();
+
+  setup(() => {
+    sandbox = sinon.createSandbox();
+
+    sandbox.stub(jsCore, 'mergeIntoExistingPackageJson');
+  });
+
+  teardown(() => sandbox.restore());
+
   test('that that the badge and version string are generated', async () => {
     assert.deepEqual(
-      await scaffoldSemanticRelease(),
+      await scaffoldSemanticRelease({projectRoot}),
       {
-        packageProperties: {version: '0.0.0-semantically-released'},
         badges: {
           contribution: {
             'semantic-release': {
@@ -19,5 +33,10 @@ suite('semantic-release scaffolder', () => {
         }
       }
     );
+
+    assert.calledWith(
+      jsCore.mergeIntoExistingPackageJson,
+      {projectRoot, config: {version: '0.0.0-semantically-released'}}
+    );
   });
 });

src/semantic-release/scaffolder-test.js

@@ -1,6 +1,9 @@
-export default function () {
+import {mergeIntoExistingPackageJson} from '@form8ion/javascript-core';
+
+export default async function ({projectRoot}) {
+  await mergeIntoExistingPackageJson({projectRoot, config: {version: '0.0.0-semantically-released'}});
+
   return {
-    packageProperties: {version: '0.0.0-semantically-released'},
     badges: {
       contribution: {
         'semantic-release': {